Skip to content

Backups are stored with user configured encoding #15514

@bpasero

Description

@bpasero

I noticed in https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/backup/node/backupFileService.ts#L73 you are not passing any encoding. This means backups are potentially stored with a user choice of encoding which is not good because we should assume UTF-8 when reading backups.

I suggest to be consistent and use UTF-8 for reading and writing of all backups.

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugimportantIssue identified as high-priorityverifiedVerification succeededworkbench-hot-exitPreservation of unsaved changes across restarts

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions