Skip to content

Terminal suggest: Widget often appears after executing a command #240656

New issue
New issue
Closed
#240660
Closed
Terminal suggest: Widget often appears after executing a command#240656
#240660
Assignees
Tyriarmeganrogge
Labels
bugIssue identified by VS Code Team member as probable bugimportantIssue identified as high-priorityinsiders-releasedPatch has been released in VS Code Insidersterminal-suggestverifiedVerification succeeded
Milestone
February 2025
@Tyriar

Description

@Tyriar
Tyriar
opened on Feb 13, 2025

Repro is to just type a git subcommand quickly (initial wait is the addon loading):

Image

Maybe related to the cancelation token not be canceled here from a recent change:

vscode/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts

Lines 716 to 720 in bae7c03

hideSuggestWidget(): void {
this._currentPromptInputState = undefined;
this._leadingLineContent = undefined;
this._suggestWidget?.hide();
}

We likely need to listen for PromptInputModel.onDidFinishInput and cancel at that point instead.

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugimportantIssue identified as high-priorityinsiders-releasedPatch has been released in VS Code Insidersterminal-suggestverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions