Skip to content

Window with VS Code instance ignores integrated terminal confirmation on exit #92881

@yialo

Description

@yialo

After installation of Node.js 12.16.1 there is no chance to prevent accidental close of IDE with working terminal by setting option Terminal -> Integrated -> Confirm On Exit to true. Popup message with dialog appears, but VS Code doesn't wait for user choice and closes itself almost immediately after the 'window-close' trigger fires.
Previous version of Node.js was 12.13, the behavior was correct on it.

  • VSCode Version: 1.43.0 (user setup)
  • OS Version: Windows 10 Pro x64, version 1909, build 18363.720

Steps to Reproduce:

  1. Install Node.js v12.16.1.
  2. Install Git for Windows v2.25.1-64-bit.
  3. Set option "terminal.integrated.confirmOnExit": true.
  4. Set option "terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe".
  5. Launch Developer: Reload Window from Command Palette, or close window with IDE instance via click on cross-button, or push Alt + F4 keyboard shortcut.

Does this issue occur when all extensions are disabled?: Yes

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugterminalGeneral terminal issues that don't fall under another labelverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions