-
Notifications
You must be signed in to change notification settings - Fork 549
Update tutorial-containerize-simple-web-app-for-app-service.md #1414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The startup-file flag was not set when creating the web app resulting in the web app not working. The web app would simply remain stuck at 'loading' in the browser. Fortunately the startup.sh was given, but simply not used.
|
@romusters : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit d0352a4: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
|
Hi @romusters, Thanks very much for pointing out this error in our documentation. You're right, FastAPI will hang without the startup command, which fires up uvicorn. However, Flask doesn't need a startup command. I'm going to create a PR that gives separate commands for Flask and FastAPI. To that end, I'm going to close this PR. Please check the article in the next day or two and you should see the update. Again, thanks very much for your help with this -- it's much appreciated! -Jimaco |
|
Hi @romusters When I tried this, I found that the FastAPI app worked without adding a startup command. You do have to wait a bit in the browser for the page to appear the first time. Can you share your exact experience with this? When you say it remained "stuck in loading" it leads me to think that maybe the browser window was closed before the app had a chance to fire up and load. @bobtabor-msft FYI |
Hmm, I noticed later that pulling the docker layers took a longer then I normally used to time. So perhaps I was just impatient indeed. Apologies for wasting your time. |
|
Not a waste of time at all. Appreciate your engagement with our docs. |
The startup-file flag was not set when creating the web app resulting in the web app not working. The web app would simply remain stuck at 'loading' in the browser. Fortunately the startup.sh was given, but simply not used.