Conversation
Build.Reason:Schedule Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=559474&view=results
Build.Reason:Schedule Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=562993&view=results
Build.Reason:Schedule Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=565664&view=results
Build.Reason:Schedule Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=567337&view=results
Build.Reason:Schedule Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=570051&view=results
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
There was a problem hiding this comment.
Pull Request Overview
This PR adds no-loc metadata entries to the MSAL documentation table of contents (TOC) file to improve documentation localization handling. The changes include adding no-loc entries for various MSAL package names and component identifiers throughout the TOC structure.
- Added
no-locmetadata for all package root entries (@azure/msal-angular,@azure/msal-browser,@azure/msal-common,@azure/msal-node,@azure/msal-react) - Added
no-locentries for individual class, interface, and type names within each package section - Updated various API documentation files with new properties, methods, and type definitions
Reviewed Changes
Copilot reviewed 59 out of 59 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| msal/docs-ref-autogen/toc.yml | Added comprehensive no-loc metadata entries for package names and component identifiers throughout the TOC structure |
| Various API documentation files | Updated with new properties, method signatures, type definitions, and authentication method registration functionality |
Comments suppressed due to low confidence (4)
msal/docs-ref-autogen/@azure/msal-common/CacheHelpers.yml:1
- Similar to the isAccessTokenEntity issue, these return types should be type predicates (e.g., 'entity is CredentialEntity') or boolean, not the literal 'entity' type.
### YamlMime:TSPackage
msal/docs-ref-autogen/@azure/msal-browser/MsalCustomAuthError.yml:1
- The addition of the
errorCodes?: number[]parameter changes the constructor signature, which is a breaking change. Ensure this is handled appropriately in the public API.
### YamlMime:TSType
msal/docs-ref-autogen/@azure/msal-browser/SignUpResendCodeError.yml:1
- Corrected spelling of 'sthe' to 'the' in the description.
### YamlMime:TSType
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| content: 'function isAccessTokenEntity(entity: object): entity' | ||
| parameters: | ||
| - id: entity | ||
| type: object | ||
| description: '' | ||
| return: | ||
| description: '' | ||
| type: boolean | ||
| type: entity |
There was a problem hiding this comment.
The return type 'entity' appears to be incorrect. This should likely be a type predicate like 'entity is AccessTokenEntity' or a boolean return type, not the literal 'entity' type.
| homeAccountId: string | ||
| keyId?: string | ||
| lastUpdatedAt?: string | ||
| lastUpdatedAt: string |
There was a problem hiding this comment.
The change from optional (lastUpdatedAt?: string) to required (lastUpdatedAt: string) is a breaking change that could affect existing code. Ensure this is intentional and that migration guidance is provided if this affects public APIs.
| lastUpdatedAt: string | |
| lastUpdatedAt?: string |
|
#sign-off |
2 participants
No description provided.