Skip to content

Policy Unit Testing #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 19, 2024
Merged

Policy Unit Testing #751

merged 19 commits into from
Sep 19, 2024

Conversation

@v-akarke
Copy link
Collaborator

@v-akarke v-akarke commented May 7, 2024 •
edited
Loading

Added Unit Testing for :

  • Get-EntraMSPermissionGrantPolicy
  • New-EntraMSNamedLocationPolicy
  • New-EntraMSPermissionGrantPolicy
  • Set-EntraMSPermissionGrantPolicy
  • Add-EntraMSLifecyclePolicyGroup
  • New-EntraMSGroupLifecyclePolicy
  • Set-EntraMSGroupLifecyclePolicy
  • Get-EntraMSAuthorizationPolicy
  • Set-EntraMSAuthorizationPolicy
  • Get-EntraMSServicePrincipalDelegatedPermissionClassification
  • Get-EntraBetaMSPermissionGrantPolicy

@v-akarke
Added unit test cases for New-MgPolicyPermissionGrantPolicy,New-Entra…
9e40dbe 
…MSNamedLocationPolicy,Get-EntraMSPermissionGrantPolicy
@v-akarke v-akarke requested a review from v-varshamane May 7, 2024 11:58
@v-akarke v-akarke requested a review from a team as a code owner May 7, 2024 11:58
@learn-build-service-prod
Copy link

learn-build-service-prod bot commented May 7, 2024

Learn Build status updates of commit 9e40dbe:

✅ Validation status: passed

File Status Preview URL Details
test/module/Entra/Get-EntraMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraMSNamedLocationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

v-akarke added 2 commits May 10, 2024 14:14
@v-akarke
main pull
c00b1cc
@v-akarke
Added test cases for Set-EntraMSPermissionGrantPolicy,Add-EntraMSLife…
8a721bd 
…cyclePolicyGroup,New-EntraMSGroupLifecyclePolicy,Set-EntraMSGroupLifecyclePolicy,Get-EntraMSAuthorizationPolicy,Set-EntraMSAuthorizationPolicy
@learn-build-service-prod
Copy link

learn-build-service-prod bot commented May 10, 2024

Learn Build status updates of commit 8a721bd:

✅ Validation status: passed

File Status Preview URL Details
test/module/Entra/Add-EntraMSLifecyclePolicyGroup.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraMSAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraMSGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraMSNamedLocationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraMSAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraMSGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented May 20, 2024

Learn Build status updates of commit f57cf2f:

✅ Validation status: passed

File Status Preview URL Details
test/module/Entra/Add-EntraMSLifecyclePolicyGroup.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraMSAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraMSServicePrincipalDelegatedPermissionClassification.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraMSGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraMSNamedLocationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraMSAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraMSGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented May 28, 2024

Learn Build status updates of commit 88d728d:

✅ Validation status: passed

File Status Preview URL Details
test/module/Common-Functions.ps1 ✅Succeeded
test/module/Entra/Add-EntraMSLifecyclePolicyGroup.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraMSAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraMSServicePrincipalDelegatedPermissionClassification.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraMSGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraMSNamedLocationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraMSAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraMSGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/EntraBeta/Get-EntraBetaMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Aug 8, 2024

Learn Build status updates of commit 5910000:

✅ Validation status: passed

File Status Preview URL Details
test/module/Entra/Add-EntraMSLifecyclePolicyGroup.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraMSAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraMSServicePrincipalDelegatedPermissionClassification.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraMSGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraMSNamedLocationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraMSAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraMSGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/EntraBeta/Get-EntraBetaMSPermissionGrantPolicy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Aug 8, 2024

Learn Build status updates of commit d5639b8:

✅ Validation status: passed

File Status Preview URL Details
test/module/Entra/Add-EntraLifecyclePolicyGroup.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraServicePrincipalDelegatedPermissionClassification.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraNamedLocationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/EntraBeta/Get-EntraBetaPermissionGrantPolicy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Aug 29, 2024

Learn Build status updates of commit 0bbdb3c:

✅ Validation status: passed

File Status Preview URL Details
module/Entra/customizations/Get-EntraTrustedCertificateAuthority.ps1 ✅Succeeded
module/EntraBeta/customizations/Get-EntraBetaTrustedCertificateAuthority.ps1 ✅Succeeded
test/module/Entra/Add-EntraLifecyclePolicyGroup.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraServicePrincipalDelegatedPermissionClassification.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraNamedLocationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/EntraBeta/Get-EntraBetaPermissionGrantPolicy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Aug 29, 2024

Learn Build status updates of commit 7517a17:

✅ Validation status: passed

File Status Preview URL Details
test/module/Entra/Add-EntraLifecyclePolicyGroup.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraServicePrincipalDelegatedPermissionClassification.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraNamedLocationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/EntraBeta/Get-EntraBetaPermissionGrantPolicy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@v-varshamane v-varshamane added Ready For Review The PR Ready for Review P0 Highest priority labels Sep 2, 2024
@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Sep 4, 2024

Learn Build status updates of commit 15b807b:

✅ Validation status: passed

File Status Preview URL Details
test/module/Entra/Add-EntraLifecyclePolicyGroup.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraServicePrincipalDelegatedPermissionClassification.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraNamedLocationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/EntraBeta/Get-EntraBetaPermissionGrantPolicy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Sep 4, 2024

Learn Build status updates of commit b1405cb:

✅ Validation status: passed

File Status Preview URL Details
test/module/Entra/Add-EntraLifecyclePolicyGroup.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraServicePrincipalDelegatedPermissionClassification.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraNamedLocationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/EntraBeta/Get-EntraBetaPermissionGrantPolicy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

KenitoInc
KenitoInc reviewed Sep 19, 2024
View reviewed changes
test/module/Entra/Get-EntraAuthorizationPolicy.Tests.ps1
Mock -CommandName Get-MgPolicyAuthorizationPolicy -MockWith $scriptblock -ModuleName Microsoft.Graph.Entra
}

Describe "Get-EntraAuthorizationPolicy" {
Copy link
Collaborator

@KenitoInc KenitoInc Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test for parameter Id

Copy link
Collaborator

@snehalkotwal snehalkotwal Sep 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KenitoInc Id parameter is missing in mg graph so it is not working on the Entra cmdlet.

Copy link
Collaborator

@KenitoInc KenitoInc Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-varshamane @snehalkotwal We should update the docs https://github.com/microsoftgraph/entra-powershell/blob/main/module/docs/entra-powershell-v1.0/Microsoft.Graph.Entra/Get-EntraAuthorizationPolicy.md

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Sep 19, 2024

Learn Build status updates of commit 9f31257:

✅ Validation status: passed

File Status Preview URL Details
test/module/Entra/Add-EntraLifecyclePolicyGroup.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraServicePrincipalDelegatedPermissionClassification.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraNamedLocationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/EntraBeta/Get-EntraBetaPermissionGrantPolicy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Sep 19, 2024

Learn Build status updates of commit 210d9e8:

✅ Validation status: passed

File Status Preview URL Details
test/module/Entra/Add-EntraLifecyclePolicyGroup.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraServicePrincipalDelegatedPermissionClassification.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraNamedLocationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/EntraBeta/Get-EntraBetaPermissionGrantPolicy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

learn-build-service-prod bot commented Sep 19, 2024

Learn Build status updates of commit 24f7ef6:

✅ Validation status: passed

File Status Preview URL Details
test/module/Entra/Add-EntraLifecyclePolicyGroup.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraServicePrincipalDelegatedPermissionClassification.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraNamedLocationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/New-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraAuthorizationPolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraGroupLifecyclePolicy.Tests.ps1 ✅Succeeded
test/module/Entra/Set-EntraPermissionGrantPolicy.Tests.ps1 ✅Succeeded
test/module/EntraBeta/Get-EntraBetaPermissionGrantPolicy.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@KenitoInc KenitoInc merged commit d2beba0 into main Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KenitoInc KenitoInc KenitoInc approved these changes

@v-varshamane v-varshamane Awaiting requested review from v-varshamane

+1 more reviewer

@snehalkotwal snehalkotwal snehalkotwal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

P0 Highest priority Ready For Review The PR Ready for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@v-akarke @KenitoInc @snehalkotwal @v-varshamane @v-uansari