Skip to content

Conversation

@v-uansari
Copy link
Collaborator

No description provided.

@v-uansari v-uansari requested a review from v-varshamane May 22, 2024 12:40
@v-uansari v-uansari self-assigned this May 22, 2024
@v-uansari v-uansari requested a review from a team as a code owner May 22, 2024 12:40
@learn-build-service-prod
Copy link

Learn Build status updates of commit 71c715b:

✅ Validation status: passed

File Status Preview URL Details
test/module/Entra/Get-EntraDirSyncFeatures.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraDomainFedrationSettings.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraHasObjectsWithDirSyncProvisioningError.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 62c7c46:

⚠️ Validation status: warnings

File Status Preview URL Details
module/docs/entra-powershell-beta/Microsoft.Graph.Entra.Beta/Enable-EntraAzureADAlias.md ⚠️Warning View (entra-powershell-beta-preview) Details
module/docs/entra-powershell-beta/Microsoft.Graph.Entra.Beta/Connect-Entra.md 💡Suggestion View (entra-powershell-beta-preview) Details
module/docs/entra-powershell-beta/Microsoft.Graph.Entra.Beta/Get-EntraBetaAccountSku.md 💡Suggestion View (entra-powershell-beta-preview) Details
module/docs/entra-powershell-beta/Microsoft.Graph.Entra.Beta/Get-EntraBetaDirectorySetting.md 💡Suggestion View (entra-powershell-beta-preview) Details
.azure-pipelines/ci-build-migrate.yml ✅Succeeded
.azure-pipelines/ci-build.yml ✅Succeeded
.azure-pipelines/common-templates/esrp/codesign-migrate.yml ✅Succeeded
.azure-pipelines/common-templates/esrp/codesign-nuget-migrate.yml ✅Succeeded
.azure-pipelines/common-templates/esrp/codesign-nuget.yml ✅Succeeded
.azure-pipelines/common-templates/esrp/codesign.yml ✅Succeeded
.azure-pipelines/common-templates/install-tools.yml ✅Succeeded
.azure-pipelines/entra-powershell-release.yml ✅Succeeded
.azure-pipelines/generation-templates/generate_adapter-migrate.yml ✅Succeeded
.azure-pipelines/generation-templates/generate_adapter.yml ✅Succeeded
.azure-pipelines/onebranch-entra-powershell-ci-build.yml ✅Succeeded
.azure-pipelines/onebranch-entra-powershell-release.yml ✅Succeeded
build/Publish-LocalCompatModule.ps1 ✅Succeeded
CONTRIBUTING.md ✅Succeeded
development-docs/cmdlet-references-documentation/cmdlet-reference-example-beta.md ✅Succeeded
development-docs/cmdlet-references-documentation/cmdlet-reference-example.md ✅Succeeded
development-docs/cmdlet-references-documentation/cmdlet-reference-template.md ✅Succeeded
development-docs/cmdlet-references-documentation/sample-data/fictitious-guids.md ✅Succeeded
development-docs/cmdlet-references-documentation/sample-data/fictitious-names.md ✅Succeeded
development-docs/design-guidelines/cleaning-up-commits.md ✅Succeeded
development-docs/design-guidelines/cmdlet-best-practices.md ✅Succeeded

This comment lists only the first 25 files in the pull request.

module/docs/entra-powershell-beta/Microsoft.Graph.Entra.Beta/Enable-EntraAzureADAlias.md

  • Line 2, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
  • Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

module/docs/entra-powershell-beta/Microsoft.Graph.Entra.Beta/Connect-Entra.md

  • Line 150, Column 64: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/graph/auth-v2-user#3-request-an-access-token' will be broken in isolated environments. Replace with a relative link.
  • Line 164, Column 27: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/entra/identity-platform/v2-oauth2-device-code' will be broken in isolated environments. Replace with a relative link.
  • Line 184, Column 73: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/powershell/entra-powershell/app-only-access-auth' will be broken in isolated environments. Replace with a relative link.
  • Line 228, Column 52: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/powershell/module/microsoft.powershell.security/get-credential' will be broken in isolated environments. Replace with a relative link.
  • Line 258, Column 61: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/powershell/module/microsoft.graph.entra/get-entracontext' will be broken in isolated environments. Replace with a relative link.

module/docs/entra-powershell-beta/Microsoft.Graph.Entra.Beta/Get-EntraBetaAccountSku.md

  • Line 47, Column 176: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/entra/identity/users/licensing-service-plan-reference' will be broken in isolated environments. Replace with a relative link.

module/docs/entra-powershell-beta/Microsoft.Graph.Entra.Beta/Get-EntraBetaDirectorySetting.md

  • Line 50, Column 102: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/entra/identity/role-based-access-control/permissions-reference' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 03fbf15:

✅ Validation status: passed

File Status Preview URL Details
test/module/Entra/Get-EntraDirectoryObjectOnPremisesProvisioningError.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraDirSyncFeatures.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraDomainFederationSettings.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@v-varshamane v-varshamane added P0 Highest priority Ready For Review The PR Ready for Review labels Sep 23, 2024
@learn-build-service-prod
Copy link

Learn Build status updates of commit d5b5c17:

✅ Validation status: passed

File Status Preview URL Details
test/module/Entra/Get-EntraDirectoryObjectOnPremisesProvisioningError.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraDirSyncFeatures.Tests.ps1 ✅Succeeded
test/module/Entra/Get-EntraDomainFederationSettings.Tests.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

@learn-build-service-prod
Copy link

@learn-build-service-prod
Copy link

@KenitoInc KenitoInc merged commit 43c5544 into main Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P0 Highest priority Ready For Review The PR Ready for Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants