feature/large file align #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested review from
MIchaelMainer,
ddyett,
nikithauc and
zengin
as code owners
- removes useless method in interface - adds result wrapper for consumers for large file uploads
baywet
force-pushed
the
feature/large-file-align
branch
from
17f0660 to
ff4c540
Compare
MIchaelMainer
approved these changes
Mar 1, 2021
src/main/java/com/microsoft/graph/tasks/LargeFileUploadTask.java
Outdated
Show resolved
Hide resolved
| * | ||
| * @param <ResultType> type of the deserialized response. | ||
| */ | ||
| public class LargeFileUploadResult<ResultType> { |
There was a problem hiding this comment.
Related to this PR, we should expose response headers on the result. Perhaps this is a backlog item.
There was a problem hiding this comment.
@MIchaelMainer
Why do you think we'll need to expose other headers? I thought just the location one was required. I know you were off those days but don't hesitate to go comment additional things we might have missed here microsoftgraph/msgraph-sdk-design#42
baywet
commented
Mar 2, 2021
src/main/java/com/microsoft/graph/tasks/LargeFileUploadTask.java
Outdated
Show resolved
Hide resolved
baywet
commented
Mar 2, 2021
src/main/java/com/microsoft/graph/tasks/LargeFileUploadTask.java
Outdated
Show resolved
Hide resolved
baywet
commented
Mar 2, 2021
src/main/java/com/microsoft/graph/tasks/LargeFileUploadTask.java
Outdated
Show resolved
Hide resolved
baywet
commented
Mar 2, 2021
src/main/java/com/microsoft/graph/tasks/LargeFileUploadTask.java
Outdated
Show resolved
Hide resolved
baywet
commented
Mar 2, 2021
src/main/java/com/microsoft/graph/tasks/LargeFileUploadTask.java
Outdated
Show resolved
Hide resolved
baywet
commented
Mar 2, 2021
src/main/java/com/microsoft/graph/tasks/LargeFileUploadTask.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #159
related microsoftgraph/msgraph-sdk-java#681
related microsoftgraph/MSGraph-SDK-Code-Generator#468