fixes a bug where batch step would not respect set verbosity #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
baywet
commented
May 26, 2021
baywet
commented
- fixes Unable to change the loglevel for graph sdk #209 a bug where batch errors would not respect configured log level
baywet
requested review from
MIchaelMainer,
ddyett,
nikithauc and
zengin
as code owners
This was referenced May 26, 2021
Merged
nikithauc
reviewed
May 26, 2021
| return serializer.deserializeObject((JsonElement)body, resultClass); | ||
| } else | ||
| throw GraphServiceException.createFromResponse("", "", new ArrayList<>(), "", headers, "", status, error, false); | ||
| } else { |
There was a problem hiding this comment.
Is a unit test possible for this change?
nikithauc
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.