-
Couldn't load subscription status.
- Fork 30
fixed serialization problems for mime messages #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the contribution! LGTM. @ramsessanchez would you mind doing some additional testing please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah one thing that'd be missing is a unit test for that, sorry I forgot it on the first review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for adding the unit test @mmertens93 !
I did push a few additional commits to fix a linting issue on the unit test as well as address a missing javadoc comment from #249.
@ramsessanchez please have a look and merge at your earliest convenience.
Fixes microsoftgraph/msgraph-sdk-serviceissues#112
Changes proposed in this pull request
Additional Information