Skip to content

Conversation

@mmertens93
Copy link

Fixes microsoftgraph/msgraph-sdk-serviceissues#112

Changes proposed in this pull request

  • When sending mime messages (content-type "text/plain"), the library should not enclose the request body with double quotes

Additional Information

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution! LGTM. @ramsessanchez would you mind doing some additional testing please?

@baywet baywet added this to the 2.0.9 milestone Aug 4, 2021
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah one thing that'd be missing is a unit test for that, sorry I forgot it on the first review.

@ghost
Copy link

ghost commented Aug 5, 2021

CLA assistant check
All CLA requirements met.

@mmertens93 mmertens93 requested a review from baywet August 5, 2021 06:24
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding the unit test @mmertens93 !
I did push a few additional commits to fix a linting issue on the unit test as well as address a missing javadoc comment from #249.
@ramsessanchez please have a look and merge at your earliest convenience.

@ramsessanchez ramsessanchez merged commit c55ac30 into microsoftgraph:dev Aug 5, 2021
@baywet baywet modified the milestones: 2.0.9, 2.0.8 Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sending messages with MIME content using the SDK fails

3 participants