Add support to set a setting to serialize null values #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltSerializer and GSONFactory
ddellsperger
requested review from
MIchaelMainer,
baywet,
ddyett,
nikithauc,
ramsessanchez and
zengin
as code owners
|
|
baywet
requested changes
Aug 5, 2021
There was a problem hiding this comment.
thanks for the pull request @ddellsperger !!
A few minor comments before we can merge this in.
src/main/java/com/microsoft/graph/serializer/DefaultSerializer.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/graph/serializer/DefaultSerializerTest.java
Outdated
Show resolved
Hide resolved
baywet
reviewed
Aug 5, 2021
src/test/java/com/microsoft/graph/serializer/DefaultSerializerTest.java
Outdated
Show resolved
Hide resolved
ddellsperger
force-pushed
the
serialize-nulls
branch
from
4a37830 to
d772567
Compare
baywet
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
thanks a lot for taking in the changes. @ramsessanchez to review and merge at your earliest convenience.
ramsessanchez
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256
Changes proposed in this pull request
DefaultSerializerandGsonFactoryto set the.serializeNulls()option in theGsonBuilderto support serializing null values in the serialization output