#300 DefaultSerializer can't unit class. #301
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valenpo
requested review from
MIchaelMainer,
baywet,
ddyett,
nikithauc,
ramsessanchez and
zengin
as code owners
baywet
requested changes
Aug 31, 2021
| */ | ||
| private final ILogger logger; | ||
|
|
||
| static Function<String, String> oDataTypeToClassName = odataType -> { |
There was a problem hiding this comment.
Can you change this to a regular method instead of a delegate function please?
|
Also, your fork doesn't seem to be up to date and this pull request is conflicting, can you pull the latest and rebase your pull request please? |
|
pull to master
On 31 Aug 2021, at 14:34, Vincent Biret ***@***.***> wrote:
Also, your fork doesn't seem to be up to date and this pull request is conflicting, can you pull the latest and rebase your pull request please?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#301 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIMLQY5ID3IFHA7FYCSEWTT7S45PANCNFSM5DDSMJ3A>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
Regards,
Valentin Popov
|
|
superseded by #302, closing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300
package name should be lowercase