Skip to content

Conversation

@ramsessanchez
Copy link
Contributor

Changes proposed in this pull request

  • Publish preview and release using GithHub Actions.

@ramsessanchez ramsessanchez changed the title Create build-and-publish.yml Publish Preview and Release using GHActions Sep 1, 2021
@baywet
Copy link
Member

baywet commented Sep 1, 2021

I'm not sure why are we defining a second worfklow instead of adding this as stages to the other one being worked on in #303 ?
We should be leveraging environment to get the policies and approvals in place too.

@ramsessanchez
Copy link
Contributor Author

I'm not sure why are we defining a second worfklow instead of adding this as stages to the other one being worked on in #303 ?
We should be leveraging environment to get the policies and approvals in place too.

My thought was that this action would be exclusive to case when the pull-request is approved and merged and thus ready for preview/release. In a similar fashion the other action would be exclusive to the case when we only want to verify that a pull request builds successfully. I can add them as separate jobs with the publishing job being dependent on the build job if that's preferred.

@baywet
Copy link
Member

baywet commented Sep 2, 2021

Fair point, we don't need it to be after the build anymore since we're moving to source promotion.
However we do need it to be a deployment job, so we can use environments and have environment policies (with approvals), what I don't know is whether we can have a deployment job by itself (without a build job before).
We'll at least need two different stages in this file, one for the release feed (master) and one for the preview feed (dev) as we'll need to map to the different environments.
Let's keep going with two files (build & pr validation on the other PR, publish in here)

baywet
baywet previously approved these changes Sep 7, 2021
@ramsessanchez ramsessanchez marked this pull request as ready for review September 7, 2021 16:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@baywet baywet added this to the 2.0.9 milestone Sep 10, 2021
ramsessanchez and others added 2 commits September 13, 2021 10:50
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ramsessanchez ramsessanchez merged commit ca5141a into dev Sep 13, 2021
@ramsessanchez ramsessanchez deleted the rsh/publishUsingGHActions branch September 13, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants