update 300, fix 309 #310
Merged
update 300, fix 309 #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2021 09:59
(cherry picked from commit ff401f9)
valenpo
requested review from
MIchaelMainer,
baywet,
ddyett,
nikithauc,
ramsessanchez and
zengin
as code owners
baywet
requested changes
Sep 9, 2021
src/main/java/com/microsoft/graph/httpcore/TelemetryHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/graph/httpcore/TelemetryHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/graph/serializer/DerivedClassIdentifier.java
Show resolved
Hide resolved
src/test/java/com/microsoft/graph/serializer/DerivedClassIdentifierTest.java
Show resolved
Hide resolved
|
Vincent, I have no ideas how all pull requests are merged together.
|
|
yup.
|
baywet
approved these changes
Sep 9, 2021
|
perfect, I've closed the other PR, I'll let @ramsessanchez do another pass at this one before we merge it, in case I missed anything. |
ramsessanchez
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300, #309
Proper interruptedException handling