- adds support for cancelling request #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested review from
MIchaelMainer,
ddyett,
nikithauc,
ramsessanchez and
zengin
as code owners
Closed
baywet
force-pushed
the
feature/cancellable
branch
from
e206615 to
d00b2db
Compare
src/main/java/com/microsoft/graph/http/CoreHttpCallbackFutureWrapper.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
ramsessanchez
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #343
Adds support for cancelling the request
Should cancel the outgoing request.
@oprobst88 would you mind giving it a try before we merge it please?
@ramsessanchez would you mind doing some testing as well please? and when this gets merged, could you replicate into kiota http lib?