Rsh/get version script #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zengin
reviewed
Jun 25, 2020
|
|
||
| #If the api calls return empty then this library cannot be compared to the online versions | ||
| #may proceed with the pull request | ||
| if(($mavenVersion -eq $null) -and ($bintrayVersion -eq $null)) |
There was a problem hiding this comment.
Q: should we use -or instead?
There was a problem hiding this comment.
I wasn't sure here either. Initially I was thinking -or also, however I was think this would only lead to another error if there's a version conflict with either the Maven or Jcenter version and we allow it to proceed. With -and we only allow it to proceed if it has not been published to either repository.
add "Scripts/*" in pr: - paths: - exclude: within prValidate.yml
zengin
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the script 'getLatestVersion' to retrieve version in the Gradle.Properties file. The script was also included in the artifact so that it may later be accessed in the Java-Core release pipeline. This script is used to auto-tag the GH releases in the Java-Core release pipeline.
Also updated the validateMavenVersion script to take into account the case where we may not have published anything to either the Jcenter or Maven repos. This is more so a provision for any future scenarios which may occur.