Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 20, 2020

Bumps okhttp from 3.12.1 to 4.8.1.

Changelog

Sourced from okhttp's changelog.

Version 4.8.1

2020-08-06

  • Fix: Don't crash in HeldCertificate.Builder when creating certificates on older versions of Android, including Android 6. We were using a feature of SimpleDateFormat that wasn't available in those versions!

Version 4.8.0

2020-07-11

  • New: Change HeldCertificate.Builder to use its own ASN.1 certificate encoder. This is part of our effort to remove the okhttp-tls module's dependency on Bouncy Castle. We think Bouncy Castle is great! But it's a large dependency (6.5 MiB) and its security provider feature impacts VM-wide behavior.

  • New: Reduce contention for applications that make a very high number of concurrent requests. Previously OkHttp used its connection pool as a lock when making changes to connections and calls. With this change each connection is locked independently.

  • Upgrade: [Okio 2.7.0][okio_2_7_0].

    implementation("com.squareup.okio:okio:2.7.0")
  • Fix: Avoid log messages like "Didn't find class org.conscrypt.ConscryptHostnameVerifier" when detecting the TLS capabilities of the host platform.

  • Fix: Don't crash in HttpUrl.topPrivateDomain() when the hostname is malformed.

  • Fix: Don't attempt Brotli decompression if the response body is empty.

Version 4.7.2

2020-05-20

  • Fix: Don't crash inspecting whether the host platform is JVM or Android. With 4.7.0 and 4.7.1 we had a crash IllegalArgumentException: Not a Conscrypt trust manager because we depended on initialization order of companion objects.

Version 4.7.1

2020-05-18

  • Fix: Pass the right arguments in the trust manager created for addInsecureHost(). Without the
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Aug 20, 2020
@baywet baywet self-assigned this Aug 20, 2020
@dependabot dependabot bot force-pushed the dependabot/gradle/com.squareup.okhttp3-okhttp-4.8.1 branch from 5240ecc to fc2e292 Compare August 20, 2020 12:53
Bumps [okhttp](https://github.com/square/okhttp) from 3.12.1 to 4.8.1.
- [Release notes](https://github.com/square/okhttp/releases)
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](square/okhttp@parent-3.12.1...parent-4.8.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/com.squareup.okhttp3-okhttp-4.8.1 branch from fc2e292 to 5970969 Compare August 20, 2020 12:57
@baywet baywet added this to the 2.0.0 milestone Aug 24, 2020
Bumps [okhttp](https://github.com/square/okhttp) from 3.12.1 to 4.8.1.
- [Release notes](https://github.com/square/okhttp/releases)
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](square/okhttp@parent-3.12.1...parent-4.8.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/com.squareup.okhttp3-okhttp-4.8.1 branch from 5970969 to 69a56e5 Compare August 24, 2020 17:15
@baywet baywet modified the milestones: 2.0.0, 1.0.2 Aug 24, 2020
@baywet baywet requested review from MIchaelMainer and zengin August 24, 2020 17:16
@baywet baywet modified the milestones: 1.0.2, 2.0.0 Aug 24, 2020
@baywet
Copy link
Member

baywet commented Aug 24, 2020

NOTE: there's a bunch of references to okhttp3 in the code which I think we need to upgrade as well.
Also, this would probably need to be coordinated with the service library to avoid breaking E2E experience. Pushing to milestone 2.0.0

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 14, 2020

A newer version of com.squareup.okhttp3:okhttp exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@baywet baywet changed the base branch from dev to feature/v2 October 5, 2020 19:23
@baywet baywet requested review from ddyett and nikithauc October 5, 2020 19:23
@baywet
Copy link
Member

baywet commented Oct 5, 2020

depends on #58

@baywet baywet merged commit 2794ba5 into feature/v2 Oct 5, 2020
@baywet baywet deleted the dependabot/gradle/com.squareup.okhttp3-okhttp-4.8.1 branch October 5, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant