Skip to content

feature/url-regex-replace-improvement #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2020
Merged

feature/url-regex-replace-improvement #90

merged 1 commit into from
Nov 30, 2020

Conversation

@baywet
Copy link
Member

@baywet baywet commented Nov 25, 2020 •
edited
Loading

fixes #66

@baywet baywet self-assigned this Nov 25, 2020
@baywet baywet added this to the 2.0.0 milestone Nov 25, 2020
@baywet baywet merged commit 6696aec into dev Nov 30, 2020
@baywet baywet deleted the feature/url-regex-replace-improvement branch November 30, 2020 19:42
@lespea
Copy link

lespea commented Dec 1, 2020

Could you also compile the regex just once? I don't think the jvm optimizes that automatically but maybe I'm wrong.

@baywet baywet mentioned this pull request Dec 1, 2020
Merged
@baywet
Copy link
Member Author

baywet commented Dec 1, 2020

@lespea thanks for the feedback. I'm used to languages that do that automatically for you and didn't consider that. I've authored #91 to address that comment.

@baywet baywet mentioned this pull request Dec 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

1 more reviewer

@zengin zengin zengin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@baywet baywet

Labels

None yet

Projects

None yet

Milestone

2.0.0-preview

Development

Successfully merging this pull request may close these issues.

Refactor url replacement in batch to use single regex

4 participants

@baywet @lespea @zengin