Skip to content

Conversation

@nikithauc
Copy link
Contributor

No description provided.

Copy link
Contributor

@MIchaelMainer MIchaelMainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does build or test run linter?
Also, can you add CredScan and Component Governance tasks as the first two tasks?

Please name this pipeline with the name: field. Please change the file name to be more descriptive of what this pipeline does. Then you can use $(BuildDefinitionName) as part of the name: so you match the filename with the name that shows up in the Azure Pipelines UI.

Please be explicit about whether this is supposed to run on PR and/or commits. Give path specs that limit the type of changes that should result in a new build. Give branch specs as well since we don't want this to run on all branches. Here's some reference.

baywet
baywet previously approved these changes Nov 2, 2022
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking in the suggestions!

@baywet baywet requested a review from MIchaelMainer November 2, 2022 10:46
MIchaelMainer
MIchaelMainer previously approved these changes Nov 2, 2022
@nikithauc nikithauc dismissed stale reviews from MIchaelMainer and baywet via 3434c2d November 2, 2022 17:45
MIchaelMainer
MIchaelMainer previously approved these changes Nov 2, 2022
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nikithauc nikithauc merged commit 9e2ff17 into dev Nov 2, 2022
@baywet baywet deleted the nikithauc/buildPipeline branch November 30, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants