Skip to content

Conversation

@krototype
Copy link
Contributor

@krototype krototype commented Aug 9, 2019

Summary

Updated the type of body that was passed to Response object, so that it works fine for the returned json in case of Batching.

Motivation

Explain the motivation for making this change. What existing problem does the pull request solve?
The BatchResponseContent was not sending the Response body in the correct format for json response type.

Fixes #204

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@krototype krototype merged commit 73177f0 into dev Aug 13, 2019
@nikithauc nikithauc deleted the abhsriva/BatchResponseContent branch September 2, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Batching - unable to get .json() to work on json response

3 participants