Skip to content

Conversation

@acristu
Copy link

@acristu acristu commented Feb 10, 2022

quickfix for #529

@sebastienlevert
Copy link
Contributor

Thanks for your contribution @acristu! We will be reviewing and merge when ready! This will be available in our next version of the SDK!

@acristu
Copy link
Author

acristu commented Feb 10, 2022

no pb, sry this was in a hurry, don't have time to run all tests and make a proper PR

actually on my end I just modified the js file dirrectly in node_modules, I need to do a quick PoC ... so for me this workaround is sufficient for now...

@nikithauc
Copy link
Contributor

@acristu Thank you so much for this contribution!

Unfortunately at present, the library expects an encoded URI to be passed as a parameter. We have customers passing in an encoded URI and I would recommend this as a workaround now.

I labelled this PR as a breaking change considering cases of encoding already encoded URLs which would break some customers.

@acristu
Copy link
Author

acristu commented Feb 16, 2022

Hi @nikithauc , thanks for the reply, so this means the 3min Graph intro node.js app should be fixed to send startDateTime/endDateTime in URI encoded format ? I was following the intro when I hit this issue ... the downloaded app did not work for me ...

@nikithauc
Copy link
Contributor

Hi @nikithauc , thanks for the reply, so this means the 3min Graph intro node.js app should be fixed to send startDateTime/endDateTime in URI encoded format ? I was following the intro when I hit this issue ... the downloaded app did not work for me ...

Thanks for bringing this to attention! Let me verify this and make the necessary updates:)

@nikithauc
Copy link
Contributor

#823

@nikithauc nikithauc closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants