Create two different output js files on with vendor polyfills and one without #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc: @lahuey |
|
@muthurathinam Can you add package, which will get generated after this change, as a comment here? |
Contributor
Author
|
Output files:
|
ghost
previously approved these changes
Aug 6, 2018
MIchaelMainer
requested changes
Aug 6, 2018
Contributor
MIchaelMainer
left a comment
MIchaelMainer
left a comment
There was a problem hiding this comment.
Please add information in the readme about the two output files.
… and one" This reverts commit d16fdfc.
without. 2.Update README.md file
… and one" This reverts commit 57ee9b6.
Contributor
Author
|
@MIchaelMainer I have updated the README.md file. |
MIchaelMainer
approved these changes
Aug 7, 2018
darrelmiller
approved these changes
Aug 9, 2018
Contributor
darrelmiller
left a comment
darrelmiller
left a comment
There was a problem hiding this comment.
Looks good to me, although this is way out of realm of experience, so don't put too much weight in my opinion!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two output js files are created
Polyfills for fetchapi and es6-promises are more common, so the host applications might already have the copies of these polyfills. Having ouput without polyfill will actually reduce the sdk file size which fastens the js loading.