Skip to content

Commit 92cfeb7

Browse files
authored
Remove invalid commands (#830)
* Add Teams test. * Update tests. * Clean commands in Planner module. * Remove invalid teams cmdlets.
1 parent 6bccdff commit 92cfeb7

File tree

7 files changed

+295
-152
lines changed

7 files changed

+295
-152
lines changed

src/Planner/Planner/Microsoft.Graph.Planner.psd1

Lines changed: 24 additions & 99 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
#
44
# Generated by: Microsoft Corporation
55
#
6-
# Generated on: 8/25/2020
6+
# Generated on: 8/13/2021
77
#
88

99
@{
@@ -12,13 +12,13 @@
1212
RootModule = './Microsoft.Graph.Planner.psm1'
1313

1414
# Version number of this module.
15-
ModuleVersion = '0.9.2'
15+
ModuleVersion = '1.6.0'
1616

1717
# Supported PSEditions
1818
CompatiblePSEditions = 'Core', 'Desktop'
1919

2020
# ID used to uniquely identify this module
21-
GUID = '2e32ec29-c1fe-4c32-a40f-5887ecc3312e'
21+
GUID = '0123fa4f-9cdc-4098-8bfb-8aa89b5da9fa'
2222

2323
# Author of this module
2424
Author = 'Microsoft Corporation'
@@ -51,7 +51,7 @@ DotNetFrameworkVersion = '4.7.2'
5151
# ProcessorArchitecture = ''
5252

5353
# Modules that must be imported into the global environment prior to importing this module
54-
RequiredModules = @(@{ModuleName = 'Microsoft.Graph.Authentication'; ModuleVersion = '0.9.1'; })
54+
RequiredModules = @(@{ModuleName = 'Microsoft.Graph.Authentication'; ModuleVersion = '1.6.0'; })
5555

5656
# Assemblies that must be loaded prior to importing this module
5757
RequiredAssemblies = './bin/Microsoft.Graph.Planner.private.dll'
@@ -70,17 +70,9 @@ FormatsToProcess = './Microsoft.Graph.Planner.format.ps1xml'
7070

7171
# Functions to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no functions to export.
7272
FunctionsToExport = 'Get-MgGroupPlanner', 'Get-MgGroupPlannerPlan',
73-
'Get-MgGroupPlannerPlanBucket', 'Get-MgGroupPlannerPlanBucketTask',
74-
'Get-MgGroupPlannerPlanBucketTaskAssignedToTaskBoardFormat',
75-
'Get-MgGroupPlannerPlanBucketTaskBoardFormat',
76-
'Get-MgGroupPlannerPlanBucketTaskDetail',
77-
'Get-MgGroupPlannerPlanBucketTaskProgressTaskBoardFormat',
78-
'Get-MgGroupPlannerPlanDetail', 'Get-MgGroupPlannerPlanTask',
79-
'Get-MgGroupPlannerPlanTaskAssignedToTaskBoardFormat',
80-
'Get-MgGroupPlannerPlanTaskBucketTaskBoardFormat',
81-
'Get-MgGroupPlannerPlanTaskDetail',
82-
'Get-MgGroupPlannerPlanTaskProgressTaskBoardFormat',
83-
'Get-MgPlanner', 'Get-MgPlannerBucket', 'Get-MgPlannerBucketTask',
73+
'Get-MgGroupPlannerPlanBucket', 'Get-MgGroupPlannerPlanDetail',
74+
'Get-MgGroupPlannerPlanTask', 'Get-MgPlanner', 'Get-MgPlannerBucket',
75+
'Get-MgPlannerBucketTask',
8476
'Get-MgPlannerBucketTaskAssignedToTaskBoardFormat',
8577
'Get-MgPlannerBucketTaskBoardFormat',
8678
'Get-MgPlannerBucketTaskDetail',
@@ -95,48 +87,22 @@ FunctionsToExport = 'Get-MgGroupPlanner', 'Get-MgGroupPlannerPlan',
9587
'Get-MgPlannerPlanTaskAssignedToTaskBoardFormat',
9688
'Get-MgPlannerPlanTaskBucketTaskBoardFormat',
9789
'Get-MgPlannerPlanTaskDetail',
98-
'Get-MgPlannerPlanTaskProgressTaskBoardFormat', 'Get-MgPlannerTask',
99-
'Get-MgPlannerTaskAssignedToTaskBoardFormat',
90+
'Get-MgPlannerPlanTaskProgressTaskBoardFormat',
91+
'Get-MgPlannerRoster', 'Get-MgPlannerRosterMember',
92+
'Get-MgPlannerRosterPlan', 'Get-MgPlannerRosterPlanByRef',
93+
'Get-MgPlannerTask', 'Get-MgPlannerTaskAssignedToTaskBoardFormat',
10094
'Get-MgPlannerTaskBucketTaskBoardFormat', 'Get-MgPlannerTaskDetail',
10195
'Get-MgPlannerTaskProgressTaskBoardFormat', 'Get-MgUserPlanner',
102-
'Get-MgUserPlannerFavoritePlan',
103-
'Get-MgUserPlannerFavoritePlanByRef', 'Get-MgUserPlannerPlan',
104-
'Get-MgUserPlannerPlanBucket', 'Get-MgUserPlannerPlanBucketTask',
105-
'Get-MgUserPlannerPlanBucketTaskAssignedToTaskBoardFormat',
106-
'Get-MgUserPlannerPlanBucketTaskBoardFormat',
107-
'Get-MgUserPlannerPlanBucketTaskDetail',
108-
'Get-MgUserPlannerPlanBucketTaskProgressTaskBoardFormat',
109-
'Get-MgUserPlannerPlanDetail', 'Get-MgUserPlannerPlanTask',
110-
'Get-MgUserPlannerPlanTaskAssignedToTaskBoardFormat',
111-
'Get-MgUserPlannerPlanTaskBucketTaskBoardFormat',
112-
'Get-MgUserPlannerPlanTaskDetail',
113-
'Get-MgUserPlannerPlanTaskProgressTaskBoardFormat',
114-
'Get-MgUserPlannerRecentPlan', 'Get-MgUserPlannerRecentPlanByRef',
115-
'Get-MgUserPlannerTask',
116-
'Get-MgUserPlannerTaskAssignedToTaskBoardFormat',
117-
'Get-MgUserPlannerTaskBucketTaskBoardFormat',
118-
'Get-MgUserPlannerTaskDetail',
119-
'Get-MgUserPlannerTaskProgressTaskBoardFormat',
120-
'New-MgGroupPlannerPlan', 'New-MgGroupPlannerPlanBucket',
121-
'New-MgGroupPlannerPlanBucketTask', 'New-MgGroupPlannerPlanTask',
122-
'New-MgPlannerBucket', 'New-MgPlannerBucketTask', 'New-MgPlannerPlan',
96+
'Get-MgUserPlannerFavoritePlan', 'Get-MgUserPlannerPlan',
97+
'Get-MgUserPlannerRecentPlan', 'Get-MgUserPlannerRosterPlan',
98+
'Get-MgUserPlannerTask', 'New-MgGroupPlannerPlanBucket',
99+
'New-MgGroupPlannerPlanTask', 'New-MgPlannerBucket',
100+
'New-MgPlannerBucketTask', 'New-MgPlannerPlan',
123101
'New-MgPlannerPlanBucket', 'New-MgPlannerPlanBucketTask',
124-
'New-MgPlannerPlanTask', 'New-MgPlannerTask',
125-
'New-MgUserPlannerFavoritePlanByRef', 'New-MgUserPlannerPlan',
126-
'New-MgUserPlannerPlanBucket', 'New-MgUserPlannerPlanBucketTask',
127-
'New-MgUserPlannerPlanTask', 'New-MgUserPlannerRecentPlanByRef',
128-
'New-MgUserPlannerTask', 'Remove-MgGroupPlanner',
129-
'Remove-MgGroupPlannerPlan', 'Remove-MgGroupPlannerPlanBucket',
130-
'Remove-MgGroupPlannerPlanBucketTask',
131-
'Remove-MgGroupPlannerPlanBucketTaskAssignedToTaskBoardFormat',
132-
'Remove-MgGroupPlannerPlanBucketTaskBoardFormat',
133-
'Remove-MgGroupPlannerPlanBucketTaskDetail',
134-
'Remove-MgGroupPlannerPlanBucketTaskProgressTaskBoardFormat',
102+
'New-MgPlannerPlanTask', 'New-MgPlannerRoster',
103+
'New-MgPlannerRosterMember', 'New-MgPlannerRosterPlanByRef',
104+
'New-MgPlannerTask', 'Remove-MgGroupPlannerPlanBucket',
135105
'Remove-MgGroupPlannerPlanDetail', 'Remove-MgGroupPlannerPlanTask',
136-
'Remove-MgGroupPlannerPlanTaskAssignedToTaskBoardFormat',
137-
'Remove-MgGroupPlannerPlanTaskBucketTaskBoardFormat',
138-
'Remove-MgGroupPlannerPlanTaskDetail',
139-
'Remove-MgGroupPlannerPlanTaskProgressTaskBoardFormat',
140106
'Remove-MgPlannerBucket', 'Remove-MgPlannerBucketTask',
141107
'Remove-MgPlannerBucketTaskAssignedToTaskBoardFormat',
142108
'Remove-MgPlannerBucketTaskBoardFormat',
@@ -153,40 +119,14 @@ FunctionsToExport = 'Get-MgGroupPlanner', 'Get-MgGroupPlannerPlan',
153119
'Remove-MgPlannerPlanTaskBucketTaskBoardFormat',
154120
'Remove-MgPlannerPlanTaskDetail',
155121
'Remove-MgPlannerPlanTaskProgressTaskBoardFormat',
122+
'Remove-MgPlannerRoster', 'Remove-MgPlannerRosterMember',
156123
'Remove-MgPlannerTask',
157124
'Remove-MgPlannerTaskAssignedToTaskBoardFormat',
158125
'Remove-MgPlannerTaskBucketTaskBoardFormat',
159126
'Remove-MgPlannerTaskDetail',
160127
'Remove-MgPlannerTaskProgressTaskBoardFormat',
161-
'Remove-MgUserPlanner', 'Remove-MgUserPlannerPlan',
162-
'Remove-MgUserPlannerPlanBucket',
163-
'Remove-MgUserPlannerPlanBucketTask',
164-
'Remove-MgUserPlannerPlanBucketTaskAssignedToTaskBoardFormat',
165-
'Remove-MgUserPlannerPlanBucketTaskBoardFormat',
166-
'Remove-MgUserPlannerPlanBucketTaskDetail',
167-
'Remove-MgUserPlannerPlanBucketTaskProgressTaskBoardFormat',
168-
'Remove-MgUserPlannerPlanDetail', 'Remove-MgUserPlannerPlanTask',
169-
'Remove-MgUserPlannerPlanTaskAssignedToTaskBoardFormat',
170-
'Remove-MgUserPlannerPlanTaskBucketTaskBoardFormat',
171-
'Remove-MgUserPlannerPlanTaskDetail',
172-
'Remove-MgUserPlannerPlanTaskProgressTaskBoardFormat',
173-
'Remove-MgUserPlannerTask',
174-
'Remove-MgUserPlannerTaskAssignedToTaskBoardFormat',
175-
'Remove-MgUserPlannerTaskBucketTaskBoardFormat',
176-
'Remove-MgUserPlannerTaskDetail',
177-
'Remove-MgUserPlannerTaskProgressTaskBoardFormat',
178-
'Update-MgGroupPlanner', 'Update-MgGroupPlannerPlan',
179-
'Update-MgGroupPlannerPlanBucket',
180-
'Update-MgGroupPlannerPlanBucketTask',
181-
'Update-MgGroupPlannerPlanBucketTaskAssignedToTaskBoardFormat',
182-
'Update-MgGroupPlannerPlanBucketTaskBoardFormat',
183-
'Update-MgGroupPlannerPlanBucketTaskDetail',
184-
'Update-MgGroupPlannerPlanBucketTaskProgressTaskBoardFormat',
128+
'Update-MgGroupPlanner', 'Update-MgGroupPlannerPlanBucket',
185129
'Update-MgGroupPlannerPlanDetail', 'Update-MgGroupPlannerPlanTask',
186-
'Update-MgGroupPlannerPlanTaskAssignedToTaskBoardFormat',
187-
'Update-MgGroupPlannerPlanTaskBucketTaskBoardFormat',
188-
'Update-MgGroupPlannerPlanTaskDetail',
189-
'Update-MgGroupPlannerPlanTaskProgressTaskBoardFormat',
190130
'Update-MgPlanner', 'Update-MgPlannerBucket',
191131
'Update-MgPlannerBucketTask',
192132
'Update-MgPlannerBucketTaskAssignedToTaskBoardFormat',
@@ -204,28 +144,13 @@ FunctionsToExport = 'Get-MgGroupPlanner', 'Get-MgGroupPlannerPlan',
204144
'Update-MgPlannerPlanTaskBucketTaskBoardFormat',
205145
'Update-MgPlannerPlanTaskDetail',
206146
'Update-MgPlannerPlanTaskProgressTaskBoardFormat',
147+
'Update-MgPlannerRoster', 'Update-MgPlannerRosterMember',
207148
'Update-MgPlannerTask',
208149
'Update-MgPlannerTaskAssignedToTaskBoardFormat',
209150
'Update-MgPlannerTaskBucketTaskBoardFormat',
210151
'Update-MgPlannerTaskDetail',
211152
'Update-MgPlannerTaskProgressTaskBoardFormat',
212-
'Update-MgUserPlanner', 'Update-MgUserPlannerPlan',
213-
'Update-MgUserPlannerPlanBucket',
214-
'Update-MgUserPlannerPlanBucketTask',
215-
'Update-MgUserPlannerPlanBucketTaskAssignedToTaskBoardFormat',
216-
'Update-MgUserPlannerPlanBucketTaskBoardFormat',
217-
'Update-MgUserPlannerPlanBucketTaskDetail',
218-
'Update-MgUserPlannerPlanBucketTaskProgressTaskBoardFormat',
219-
'Update-MgUserPlannerPlanDetail', 'Update-MgUserPlannerPlanTask',
220-
'Update-MgUserPlannerPlanTaskAssignedToTaskBoardFormat',
221-
'Update-MgUserPlannerPlanTaskBucketTaskBoardFormat',
222-
'Update-MgUserPlannerPlanTaskDetail',
223-
'Update-MgUserPlannerPlanTaskProgressTaskBoardFormat',
224-
'Update-MgUserPlannerTask',
225-
'Update-MgUserPlannerTaskAssignedToTaskBoardFormat',
226-
'Update-MgUserPlannerTaskBucketTaskBoardFormat',
227-
'Update-MgUserPlannerTaskDetail',
228-
'Update-MgUserPlannerTaskProgressTaskBoardFormat'
153+
'Update-MgUserPlanner'
229154

230155
# Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
231156
CmdletsToExport = @()
@@ -263,7 +188,7 @@ PrivateData = @{
263188
ProjectUri = 'https://github.com/microsoftgraph/msgraph-sdk-powershell'
264189

265190
# A URL to an icon representing this module.
266-
IconUri = 'https://raw.githubusercontent.com/microsoftgraph/g-raph/master/g-raph.png'
191+
IconUri = 'https://raw.githubusercontent.com/microsoftgraph/msgraph-sdk-powershell/master/documentation/images/graph_color256.png'
267192

268193
# ReleaseNotes of this module
269194
ReleaseNotes = 'See https://aka.ms/GraphPowerShell-Release.'

src/Planner/Planner/readme.md

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,32 @@ subject-prefix: ''
4141
directive:
4242
# Remove paths that are not valid.
4343
- remove-path-by-operation: ^users.planner_(Create|Update|Delete)All$
44-
44+
# Remove cmdlets
45+
- where:
46+
verb: Remove
47+
subject: ^(User|Group)Planner$
48+
remove: true
49+
- where:
50+
verb: Remove|New|Update
51+
subject: ^(User|Group)Planner(Task|Plan)$
52+
remove: true
53+
# Only list is supported.
54+
- where:
55+
verb: Get
56+
variant: Get.*
57+
subject: ^UserPlanner(Task|Plan)$
58+
remove: true
59+
- where:
60+
verb: Get
61+
variant: Get.*
62+
subject: ^UserPlannerPlanTask$
63+
remove: true
64+
- where:
65+
subject: ^UserPlanner(Task[A-Z].*|Plan[A-Z].*)$
66+
remove: true
67+
- where:
68+
subject: ^GroupPlanner(PlanBucket[A-Z].*|PlanTask[A-Z].*)$
69+
remove: true
4570
```
4671
### Versioning
4772
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
# ------------------------------------------------------------------------------
2+
# Copyright (c) Microsoft Corporation. All Rights Reserved. Licensed under the MIT License. See License in the project root for license information.
3+
# ------------------------------------------------------------------------------
4+
5+
Describe "Microsoft.Graph.Teams module" {
6+
BeforeAll {
7+
$ModuleName = "Microsoft.Graph.Teams"
8+
$ModulePath = Join-Path $PSScriptRoot "..\$ModuleName.psd1"
9+
$PSModuleInfo = Import-Module $ModulePath -Force -PassThru
10+
}
11+
12+
AfterAll {
13+
Remove-Module $ModuleName -Force
14+
}
15+
16+
Context "On module import" {
17+
It 'Should be compatible with PS core and desktop' {
18+
{
19+
$PSModuleInfo.CompatiblePSEditions | Should -BeIn @("Core", "Desktop")
20+
} | Should -Not -Throw
21+
}
22+
23+
It 'Should point to script module' {
24+
{
25+
$PSModuleInfo.Path | Should -BeLikeExactly "*$ModuleName.psm1"
26+
} | Should -Not -Throw
27+
}
28+
29+
It 'Should have a definition' {
30+
{
31+
$PSModuleInfo.Definition | Should -Not -BeNullOrEmpty
32+
} | Should -Not -Throw
33+
}
34+
35+
It 'Should not export suppressed commands' {
36+
{
37+
$SuppressedCommands = @(
38+
"Update-MgUserPlannerTask",
39+
"New-MgUserPlannerTask",
40+
"Remove-MgUserPlannerTask",
41+
"Get-MgUserPlannerPlanTask",
42+
"Get-MgUserPlannerFavoritePlanByRef",
43+
"New-MgUserPlannerFavoritePlanByRef",
44+
"New-MgUserPlannerPlanTask",
45+
"Remove-MgUserPlannerPlanTask"
46+
)
47+
48+
$SuppressedCommands | Should -Not -BeIn $PSModuleInfo.ExportedCommands.Keys
49+
} | Should -Not -Throw
50+
}
51+
52+
It 'Should export expected commands' {
53+
{
54+
$ExpectedCommands = @(
55+
"Get-MgUserPlannerTask",
56+
"Get-MgUserPlannerFavoritePlan"
57+
)
58+
59+
$ExpectedCommands | Should -BeIn $PSModuleInfo.ExportedCommands.Keys
60+
} | Should -Not -Throw
61+
}
62+
}
63+
}

0 commit comments

Comments
 (0)