Updated file to handle non json responses

[timayabi2020]

Fixes #1425
This PR addresses an issue raised here

Changes proposed in this pull request

• Invoke-MgGraphRequest throws an error requiring -OutputFilePath when it can't process non-JSON responses
• Writes results to console if -OutputType HttpResponseMessage argument is provided

Throws an error

Writes result to console

Writes result to file

[peombwa]

-OutputFilePath is only needed for non-json responses. Let's change the contentType condition to !contentType.Equals("application/json").

[peombwa]

@timayabi2020, we should return the HTTP response object as a HttpResponseMessage type when -OutputType HttpResponseMessage is specified. See existing switch statement for -OutputType at

msgraph-sdk-powershell/src/Authentication/Authentication/Cmdlets/InvokeMgGraphRequest.cs

Lines 455 to 457 in f2f1edf

	case OutputType.HttpResponseMessage:
	WriteObject(response);
	break;

[peombwa]

@timayabi2020, can't we fix #1425 by changing:

msgraph-sdk-powershell/src/Authentication/Authentication/Cmdlets/InvokeMgGraphRequest.cs

Lines 438 to 483 in f2f1edf

	var returnType = response.CheckReturnType();
	if (returnType == RestReturnType.Json)
	{
	var responseString = await response.Content.ReadAsStringAsync();
	ErrorRecord error;
	switch (OutputType)
	{
	case OutputType.HashTable:
	var hashTable = responseString.ConvertFromJson(true, null, out error);
	ThrowIfError(error);
	WriteObject(hashTable);
	break;
	case OutputType.PSObject:
	var psObject = responseString.ConvertFromJson(false, null, out error);
	ThrowIfError(error);
	WriteObject(psObject, true);
	break;
	case OutputType.HttpResponseMessage:
	WriteObject(response);
	break;
	case OutputType.Json:
	WriteObject(responseString);
	break;
	default:
	throw new ArgumentOutOfRangeException();
	}
	}
	else if (returnType == RestReturnType.Image)
	{
	var errorRecord =
	GetValidationError(Resources.NonJsonResponseWithoutOutputFilePath,
	ErrorConstants.Codes.InvokeGraphContentTypeException, returnType);
	ThrowIfError(errorRecord);
	}
	else if (returnType == RestReturnType.Detect)
	{
	var responseString = await response.Content.ReadAsStringAsync();
	WriteObject(responseString);
	}
	else if (returnType == RestReturnType.OctetStream)
	{
	var errorRecord =
	GetValidationError(Resources.NonJsonResponseWithoutInfer,
	ErrorConstants.Codes.InvokeGraphContentTypeException, returnType, response.Content.Headers.ContentDisposition);
	ThrowIfError(errorRecord);
	}

to:

var returnType = response.CheckReturnType();
switch (returnType)
{
    case RestReturnType.Json:
        ErrorRecord error;
        string responseString;
        switch (OutputType)
        {
            case OutputType.HashTable:
                responseString = await response.Content.ReadAsStringAsync();
                var hashTable = responseString.ConvertFromJson(true, null, out error);
                ThrowIfError(error);
                WriteObject(hashTable);
                break;
            case OutputType.PSObject:
                responseString = await response.Content.ReadAsStringAsync();
                var psObject = responseString.ConvertFromJson(false, null, out error);
                ThrowIfError(error);
                WriteObject(psObject, true);
                break;
            case OutputType.HttpResponseMessage:
                WriteObject(response);
                break;
            case OutputType.Json:
                responseString = await response.Content.ReadAsStringAsync();
                WriteObject(responseString);
                break;
            default:
                throw new ArgumentOutOfRangeException(nameof(OutputType));
        }
        break;
    case RestReturnType.OctetStream:
        if (OutputType == OutputType.HttpResponseMessage)
            WriteObject(response);
        else
            ThrowIfError(GetValidationError(Resources.NonJsonResponseWithoutInfer, ErrorConstants.Codes.InvokeGraphContentTypeException, returnType, response.Content.Headers.ContentDisposition));
        break;
    default:
        if (OutputType == OutputType.HttpResponseMessage)
            WriteObject(response);
        else
            ThrowIfError(GetValidationError(Resources.NonJsonResponseWithoutOutputFilePath, ErrorConstants.Codes.InvokeGraphContentTypeException, returnType));
        break;
}

This approach limits the change to just ProcessResponseAsync method.