Expose AuthContext To Function Scope #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ddyett
reviewed
Apr 8, 2020
ddyett
reviewed
Apr 8, 2020
ddyett
reviewed
Apr 8, 2020
ddyett
reviewed
Apr 8, 2020
ddyett
reviewed
Apr 8, 2020
src/Authentication/Authentication.Test/Helpers/GraphSessionTests.cs
Outdated
Show resolved
Hide resolved
ddyett
reviewed
Apr 8, 2020
src/Authentication/Authentication.Test/Helpers/GraphSessionTests.cs
Outdated
Show resolved
Hide resolved
ddyett
reviewed
Apr 8, 2020
darrelmiller
approved these changes
Apr 13, 2020
ddyett
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
GraphSessionclass which safely provides a single session instance of itself across multiple Microsoft Graph modules. This session object will be use to hold theAuthContext, thus making it accessible to both Powershell scripts/functions and inline calls. This closes #124 and #113.The PR also fixes #154, by changing how the JWT token is decoded.