Skip to content

Fixes Request Header Logging When Using WinHttpHandler #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2023
Merged

Fixes Request Header Logging When Using WinHttpHandler #2028

merged 2 commits into from
May 23, 2023

Conversation

@peombwa
Copy link
Member

@peombwa peombwa commented May 22, 2023

Fixes #1916

Changes proposed in this pull request

  • Clones request before reading/sanitizing request headers for logging to avoid thread safety issues when WinHttpHandler is used as the final handler (.NET Fx).
  • Updates how sdkVersion and client-request-id are set on outgoing request.

@peombwa peombwa self-assigned this May 22, 2023
@peombwa peombwa mentioned this pull request May 22, 2023
Closed
@peombwa peombwa linked an issue May 22, 2023 that may be closed by this pull request
Issue running Get-MgUser in v2.0.0-Preview5 - Collection was modified; enumeration operation may not execute. Possible PageSize issue in PS 5.1 #1916
Closed
@peombwa peombwa marked this pull request as ready for review May 22, 2023 20:56
@peombwa peombwa merged commit 7a20ffb into features/2.0 May 23, 2023
@peombwa peombwa deleted the po/FixFinalHttpHandler branch May 23, 2023 17:08
@jberezanski-mdg jberezanski-mdg mentioned this pull request Jun 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timayabi2020 timayabi2020 timayabi2020 approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@shemogumbe shemogumbe Awaiting requested review from shemogumbe

Assignees

@peombwa peombwa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issue running Get-MgUser in v2.0.0-Preview5 - Collection was modified; enumeration operation may not execute. Possible PageSize issue in PS 5.1

3 participants

@peombwa @timayabi2020