Skip to content

[V1]Examples Generator Script Review #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2023
Merged

[V1]Examples Generator Script Review #2055

merged 2 commits into from
May 31, 2023

Conversation

@timayabi2020
Copy link
Contributor

@timayabi2020 timayabi2020 commented May 31, 2023

Fixes #2047
This is the corresponding PRto validate this fix

Changes proposed in this pull request

  • The script ensures that extraction of external docs link parameter from open API file is method driven (GET, POST, DELETE, PATCH)
  • The script also maintains correct examples and discards wrong examples.

@timayabi2020 timayabi2020 requested a review from a team as a code owner May 31, 2023 06:13
@timayabi2020 timayabi2020 linked an issue May 31, 2023 that may be closed by this pull request
[v1] Review Examples Generator Script #2047
Closed
@timayabi2020 timayabi2020 merged commit 3281e50 into dev May 31, 2023
@peombwa peombwa deleted the 2047-v1-review-examples-generator-script branch May 31, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peombwa peombwa peombwa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v1] Review Examples Generator Script

3 participants

@timayabi2020 @peombwa