-
Notifications
You must be signed in to change notification settings - Fork 214
Making updates to WAM implementation #2100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding WAM features to msgraph-ps-sdk Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * Update src/Authentication/Authentication/Cmdlets/SetMgGraphOption.cs Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * changing -EnableLoginByWAM to bool * updates * Update src/Authentication/Authentication/Cmdlets/SetMgGraphOption.cs Co-authored-by: Peter Ombwa <peombwa@microsoft.com> --------- Co-authored-by: Peter Ombwa <peombwa@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the updates! Please see my comments below.
src/Authentication/Authentication/test/Microsoft.Graph.Authentication.Tests.ps1
Show resolved
Hide resolved
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>
|
@peombwa Also, where/how do we update the documentation to show the addition of these new features. |
@FehintolaObafemi, feature docs should be added in the docs folder at https://github.com/microsoftgraph/msgraph-sdk-powershell/tree/features/2.0/docs. You should also work with the Eunice to add the docs to the PowerShell module browser at https://github.com/MicrosoftDocs/microsoftgraph-docs-powershell when the feature moves from preview to GA. |
peombwa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes proposed in this pull request
Other links