Skip to content

Conversation

@FehintolaObafemi
Copy link
Contributor

Changes proposed in this pull request

  • Additional features and changes made in conjunction with WAM feature update

Other links

FehintolaObafemi referenced this pull request Jun 20, 2023
Adding WAM features to msgraph-ps-sdk 
Co-authored-by: Peter Ombwa <peombwa@microsoft.com>

* Update src/Authentication/Authentication/Cmdlets/SetMgGraphOption.cs

Co-authored-by: Peter Ombwa <peombwa@microsoft.com>

* changing -EnableLoginByWAM to bool

* updates

* Update src/Authentication/Authentication/Cmdlets/SetMgGraphOption.cs

Co-authored-by: Peter Ombwa <peombwa@microsoft.com>

---------

Co-authored-by: Peter Ombwa <peombwa@microsoft.com>
Copy link
Member

@peombwa peombwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates! Please see my comments below.

Co-authored-by: Peter Ombwa <peombwa@microsoft.com>
@FehintolaObafemi
Copy link
Contributor Author

@peombwa Also, where/how do we update the documentation to show the addition of these new features.

@FehintolaObafemi FehintolaObafemi requested a review from peombwa June 26, 2023 16:22
@peombwa
Copy link
Member

peombwa commented Jun 27, 2023

@peombwa Also, where/how do we update the documentation to show the addition of these new features.

@FehintolaObafemi, feature docs should be added in the docs folder at https://github.com/microsoftgraph/msgraph-sdk-powershell/tree/features/2.0/docs. You should also work with the Eunice to add the docs to the PowerShell module browser at https://github.com/MicrosoftDocs/microsoftgraph-docs-powershell when the feature moves from preview to GA.

Copy link
Member

@peombwa peombwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FehintolaObafemi FehintolaObafemi merged commit 8b98142 into features/2.0 Jun 28, 2023
@peombwa peombwa deleted the fehintolaobafemi/WAM-updates branch June 29, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants