Request Object Property Cleanup #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgend
approved these changes
Feb 19, 2021
Contributor
|
👍👍 on the test mocks. |
peombwa
added a commit
that referenced
this pull request
Mar 4, 2021
* Add DeviceManagement modules * Add importedDeviceIdentity to device enrolment * Add role management to administration * Add device management actions and functions. * Updated applications samples * Added send mail sample * Apply directive to fix wrongly named cmdlets. * Regenerate module manifests. * Remove *-UserAuthenticationMethod commands * Update src/Identity.SignIns/Identity.SignIns/readme.md Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com> * Remove TenantId, ForceRefresh and ContextScope from AccessTokenParameterSet * Add unit test. * Add directive to remove Count, Keys, and Values properties from implementations of an IAssociativeArray. * Remove new modifier for values, keys and count. * Inline ediscovery.tag and ediscovery.sourceCollection entities. * Cleanup previous device management modules. * Add deviceManamenet module. * Add deviceManagement.Action directives. * Clean up deviceManagement directives. * Remove ADO feeds from nuget.config. * Remove breaking undocumented cmdlet * Add device management profiles. * Write generation errors to pipeline. * Update weekly generation ADO pipeline to bump patch numbers. * Update users.actions module directive. * Update ADO pipeline to use the latest version of AutoREST. * Set NODE memory to 8192. * Set node memory in generation script. * Clean up pipelines. * Weekly OpenApiDocs Download (#561) Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * 1.3.2 Pre-Releases (#565) * Add directive to remove breaking undocumented API. * Bump all modules to 1.3.2 * Add rename directive to duplicate device management cmdlets. * Update readme.md * Weekly OpenApiDocs Download (#567) Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * Request Object Property Cleanup (#560) * Remove entity-id property from entities. * Add tests for New-MgInvitation. * Set user type to MicrosoftGraphUser in v1.0. * Exclude *.md files from nuget package to reduce overrall package size. (#566) * Exclude *.md files from nuget package to reduce overrall package size. * Exclude markdown files in weekly service module generation. * Simplify and handle possibility of position change. * Weekly OpenApiDocs Download (#569) Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * 1.4.0 Pre-Release (#570) * Add no-inline for Microsoft.Graph.contentType and columnDefinition. * Bump module version to 1.4.0 * Resolve Identity.Governance duplicate cmdlet. Co-authored-by: Darrel Miller <darrel.miller@microsoft.com> Co-authored-by: DeVere Dyett <ddyett@microsoft.com> Co-authored-by: Andres Canello [Microsoft] <39328890+andres-canello@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: George <1641829+finsharp@users.noreply.github.com>
peombwa
added a commit
that referenced
this pull request
Mar 10, 2021
* Add DeviceManagement modules * Add importedDeviceIdentity to device enrolment * Add role management to administration * Add device management actions and functions. * Updated applications samples * Added send mail sample * Apply directive to fix wrongly named cmdlets. * Regenerate module manifests. * Remove *-UserAuthenticationMethod commands * Update src/Identity.SignIns/Identity.SignIns/readme.md Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com> * Remove TenantId, ForceRefresh and ContextScope from AccessTokenParameterSet * Add unit test. * Add directive to remove Count, Keys, and Values properties from implementations of an IAssociativeArray. * Remove new modifier for values, keys and count. * Inline ediscovery.tag and ediscovery.sourceCollection entities. * Cleanup previous device management modules. * Add deviceManamenet module. * Add deviceManagement.Action directives. * Clean up deviceManagement directives. * Remove ADO feeds from nuget.config. * Remove breaking undocumented cmdlet * Add device management profiles. * Write generation errors to pipeline. * Update weekly generation ADO pipeline to bump patch numbers. * Update users.actions module directive. * Update ADO pipeline to use the latest version of AutoREST. * Set NODE memory to 8192. * Set node memory in generation script. * Clean up pipelines. * Weekly OpenApiDocs Download (#561) Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * 1.3.2 Pre-Releases (#565) * Add directive to remove breaking undocumented API. * Bump all modules to 1.3.2 * Add rename directive to duplicate device management cmdlets. * Update readme.md * Weekly OpenApiDocs Download (#567) Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * Request Object Property Cleanup (#560) * Remove entity-id property from entities. * Add tests for New-MgInvitation. * Set user type to MicrosoftGraphUser in v1.0. * Exclude *.md files from nuget package to reduce overrall package size. (#566) * Exclude *.md files from nuget package to reduce overrall package size. * Exclude markdown files in weekly service module generation. * Simplify and handle possibility of position change. * Weekly OpenApiDocs Download (#569) Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * 1.4.0 Pre-Release (#570) * Add no-inline for Microsoft.Graph.contentType and columnDefinition. * Bump module version to 1.4.0 * Resolve Identity.Governance duplicate cmdlet. Co-authored-by: Darrel Miller <darrel.miller@microsoft.com> Co-authored-by: DeVere Dyett <ddyett@microsoft.com> Co-authored-by: Andres Canello [Microsoft] <39328890+andres-canello@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: George <1641829+finsharp@users.noreply.github.com>
peombwa
added a commit
that referenced
this pull request
Mar 11, 2021
* Add DeviceManagement modules * Add importedDeviceIdentity to device enrolment * Add role management to administration * Add device management actions and functions. * Updated applications samples * Added send mail sample * Apply directive to fix wrongly named cmdlets. * Regenerate module manifests. * Remove *-UserAuthenticationMethod commands * Update src/Identity.SignIns/Identity.SignIns/readme.md Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com> * Remove TenantId, ForceRefresh and ContextScope from AccessTokenParameterSet * Add unit test. * Add directive to remove Count, Keys, and Values properties from implementations of an IAssociativeArray. * Remove new modifier for values, keys and count. * Inline ediscovery.tag and ediscovery.sourceCollection entities. * Cleanup previous device management modules. * Add deviceManamenet module. * Add deviceManagement.Action directives. * Clean up deviceManagement directives. * Remove ADO feeds from nuget.config. * Remove breaking undocumented cmdlet * Add device management profiles. * Write generation errors to pipeline. * Update weekly generation ADO pipeline to bump patch numbers. * Update users.actions module directive. * Update ADO pipeline to use the latest version of AutoREST. * Set NODE memory to 8192. * Set node memory in generation script. * Clean up pipelines. * Weekly OpenApiDocs Download (#561) Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * 1.3.2 Pre-Releases (#565) * Add directive to remove breaking undocumented API. * Bump all modules to 1.3.2 * Add rename directive to duplicate device management cmdlets. * Update readme.md * Weekly OpenApiDocs Download (#567) Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * Request Object Property Cleanup (#560) * Remove entity-id property from entities. * Add tests for New-MgInvitation. * Set user type to MicrosoftGraphUser in v1.0. * Exclude *.md files from nuget package to reduce overrall package size. (#566) * Exclude *.md files from nuget package to reduce overrall package size. * Exclude markdown files in weekly service module generation. * Simplify and handle possibility of position change. * Weekly OpenApiDocs Download (#569) Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * 1.4.0 Pre-Release (#570) * Add no-inline for Microsoft.Graph.contentType and columnDefinition. * Bump module version to 1.4.0 * Resolve Identity.Governance duplicate cmdlet. Co-authored-by: Darrel Miller <darrel.miller@microsoft.com> Co-authored-by: DeVere Dyett <ddyett@microsoft.com> Co-authored-by: Andres Canello [Microsoft] <39328890+andres-canello@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: George <1641829+finsharp@users.noreply.github.com> Co-authored-by: Darrel Miller <darrel.miller@microsoft.com> Co-authored-by: DeVere Dyett <ddyett@microsoft.com> Co-authored-by: Andres Canello [Microsoft] <39328890+andres-canello@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: George <1641829+finsharp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #502 by removing unnecessary
{Entity}-Idproperty from entities. This was previously throwing a conversion error when convertingMicrosoftGraphUsertoIMicrosoftGraphUser.This PR also adds tests for
New-MgInvitationto validate the fix. The tests run by mocking AutoREST's HttpPipeline infrastructure.