identity governance: reduce unneeded EM cmdlets #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @Josegto1 I have completed this PR, could you please re-review when you get a chance? Thanks |
peombwa
reviewed
Mar 17, 2021
Member
|
@markwahl-msft Thanks for the PR!! Please see my suggestion above. GitHub doesn't format it properly. |
Member
|
Thanks for the PR! We will apply the suggestions and merge the PR into Dev. This change will be available in the 1.5.0 release. |
peombwa
approved these changes
Apr 12, 2021
peombwa
added a commit
that referenced
this pull request
Apr 16, 2021
* Bump .NET Core version * Add client capability to MSAL. * Bump MS Graph core version. * Weekly OpenApiDocs Download * Safe Dependency Resolution For Side-By-Side Loading With Other Modules (#585) * Divide project into 2 assemblies. * Update build scripts to build, sign and pack auth module with core dll. * Updates ADO pipeline to also sign and strong name MSG.Authentication.Core.dll. * Add Pester tests for loading module side by side. * Add internals visible to test proj. * Load multiframework dependencies. * Weekly OpenApiDocs Download * Update agreementFile remove directive (#605) * Fix aggrement file directive. * Bump SDK version to 1.4.3. * Adds missing site permissions to sites module (#607) * Add sistes.permissions tag to module mappings. * Generate profile for sites. * Sort crawl logs. * Weekly OpenApiDocs Download (#616) Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * identity governance: reduce unneeded EM cmdlets (#577) * add suppression for autogenerated get cmdlets * remove New cmdlets * add remove set and update variants of those get cmdlets * remove search and ro cmdlets * remove cmdlets for read only links and objects * Update src/Identity.Governance/Identity.Governance/readme.md Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com> * Weekly OpenApiDocs Download (#619) Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * 1.5.0 Pre-Release (#617) * Bump SDK version to 1.5.0 * Handle duplicate cmdlet names across modules. * Update readme.md * Use version in manifest if module is not in repo. Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mark Wahl <mwahl@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to the identity governance readme.md YAML rules for autorest to suppress some of the Get- and New- cmdlets for entitlement management, particularly those which are sending URL patterns that are not documented and/or not supported. This simplifies the IT persona experience for them to understand where to start.