Update instead of overwriting sdkVersion in graph_session.py

[jobala]

[rajatdiptabiswas]

What do you mean by update instead of overwriting?
I have noticed the self.headers is being updated with the value of sdkVersion in graph_session.py.

Would you kindly let me know what exactly needs to be done?
I would like to work on this.

[jobala]

@rajatdiptabiswas thank you for your interest!

What we are doing currently, overwrites sdkVersion if any exists. What we want to do is append to the value of sdkVersion

[rajatdiptabiswas]

Hello @jobala
Thanks for the clarification!

Should I try converting the values to a list and append the new value into the list?
e.g. {'sdkVersion' : ['graph-python-SDK_VERSION_OLD', 'graph-python-SDK_VERSION']}

Or should I append to the current value using commas (or any such delimiter) to make it a list of comma-separated values?
e.g. {'sdkVersion' : 'graph-python-SDK_VERSION_OLD, graph-python-SDK_VERSION'}

[jobala]

@rajatdiptabiswas you should append the current value using commas.

[rajatdiptabiswas]

Hi @jobala!

From what I understood, the sdkVersion key-value pair should now be something like

{ 'sdkVersion' : 'graph-python-SDK_VERSION_1,graph-python-SDK_VERSION_2,graph-python-SDK_VERSION_3,' }

where SDK_VERSION_X is the actual version number in SDK_VERSION.

Is it okay to have a trailing comma or should I handle those cases too?

As for testing, should I get sdkVersion from requests.headers, split it with , and just check whether the last item is 'graph-python-SDK_VERSION' or not?

[darrelmiller]

The syntax for the SdkVersion header is here: https://github.com/microsoftgraph/msgraph-sdk-design/blob/master/middleware/TelemetryHandler.md#remarks

New values should be pre-pended to the beginning of the header value just as in User-Agent header.

[rajatdiptabiswas]

I have made the changes mentioned and have written tests as well.
I am new to writing tests, so kindly let me know if everything looks good.

Thanks in advance!