Skip to content

Task/refactor graph session #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 1, 2020
Merged

Task/refactor graph session #45

merged 14 commits into from
May 1, 2020

Conversation

@jobala
Copy link
Contributor

@jobala jobala commented Apr 28, 2020 •
edited by azure-boards bot
Loading

Overview

Changes GraphSession to take in an Azure credential object and scopes.
Removes AuthProvider

Closes #44 #45 AB#4607

@jobala jobala requested a review from ddyett April 28, 2020 07:09
ddyett
ddyett reviewed Apr 28, 2020
View reviewed changes
@ddyett
Copy link

ddyett commented Apr 28, 2020 

def test_adds_middlewares_in_order(self):

we should probably have a test that the scopes are overriden when specified at request time.

Refers to: tests/unit/test_middleware_pipeline.py:8 in 4bc0cb8. [](commit_id = 4bc0cb8, deletion_comment = False)

ddyett
ddyett reviewed Apr 28, 2020
View reviewed changes
MIchaelMainer
MIchaelMainer reviewed May 1, 2020
View reviewed changes
README.md
```

Create an authorization provider object and a list of scopes
Pass the credential object and scopes to the GraphSession constructor.
Copy link
Contributor

@MIchaelMainer MIchaelMainer May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a couple of the imports are no longer needed above on line 17.

@jobala jobala merged commit d49ea04 into dev May 1, 2020
@jobala jobala deleted the task/refactor-graph-session branch May 1, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MIchaelMainer MIchaelMainer MIchaelMainer approved these changes

+1 more reviewer

@ddyett ddyett ddyett left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pass a credential class to GraphSession instead of an auth provider

4 participants

@jobala @ddyett @MIchaelMainer