Fix contructor

Author: rkodev

src/adapter/BaseGraphRequestAdapter.ts

@@ -7,7 +7,7 @@ import {
 } from "@microsoft/kiota-abstractions";
 import { HttpClient, type ObservabilityOptions, ObservabilityOptionsImpl } from "@microsoft/kiota-http-fetchlibrary";
 import { DefaultRequestAdapter } from "@microsoft/kiota-bundle";
-import { GraphHttpClient } from "../http/GraphHttpClient.js";
+import { createGraphClientFactory } from "../http/GraphClientFactory";
 
 /**
  * Base request adapter for graph clients. Bootstraps telemetry and other aspects.
@@ -29,7 +29,7 @@ export class BaseGraphRequestAdapter extends DefaultRequestAdapter {
     authenticationProvider: AuthenticationProvider,
     parseNodeFactory: ParseNodeFactory = ParseNodeFactoryRegistry.defaultInstance,
     serializationWriterFactory: SerializationWriterFactory = SerializationWriterFactoryRegistry.defaultInstance,
-    httpClient: HttpClient = new GraphHttpClient({
+    httpClient: HttpClient = createGraphClientFactory({
       graphServiceTargetVersion,
       graphServiceLibraryClientVersion,
     }),

src/http/GraphClientFactory.ts

@@ -4,53 +4,48 @@ import { GraphHttpClient } from "./GraphHttpClient";
 import { getDefaultMiddlewares, GraphTelemetryOption } from "../middleware";
 
 /**
- * Factory class for creating instances of `GraphHttpClient`.
+ * Creates an instance of `GraphHttpClient`, with the provided middlewares and custom fetch implementation both parameters are optional.
+ * if no middlewares are provided, the default middlewares will be used.
+ * @param {GraphTelemetryOption} graphTelemetryOption - The telemetry options for the Graph client.
+ * @param {(request: string, init: RequestInit) => Promise<Response>} customFetch - The custom fetch function to use for HTTP requests.
+ * @param {BaseBearerTokenAuthenticationProvider} [authenticationProvider] - Optional authentication provider for bearer token.
+ * @param {Middleware[]} [middlewares] - Optional array of middleware to use in the HTTP pipeline.
+ * @returns {GraphHttpClient} - A new instance of `GraphHttpClient`.
+ * @example
+ * ```Typescript
+ * // Example usage of createGraphClientFactory method with graphTelemetryOption , customFetch and middlewares parameters provided
+ *  createGraphClientFactory(graphTelemetryOption, customFetch, [middleware1, middleware2]);
+ * ```
+ * @example
+ * ```Typescript
+ * // Example usage of createGraphClientFactory method with only graphTelemetryOption and customFetch parameter provided
+ * createGraphClientFactory(graphTelemetryOption, customFetch);
+ * ```
+ * @example
+ * ```Typescript
+ * // Example usage of createGraphClientFactory method with only graphTelemetryOption and middlewares parameter provided
+ * createGraphClientFactory(graphTelemetryOption, undefined, [middleware1, middleware2]);
+ * ```
+ * @example
+ * ```Typescript
+ * // Example usage of createGraphClientFactory method with only graphTelemetryOption parameter provided
+ * createGraphClientFactory(graphTelemetryOption);
+ * ```
  */
-export class GraphClientFactory {
-  /**
-   * Creates an instance of `GraphHttpClient`, with the provided middlewares and custom fetch implementation both parameters are optional.
-   * if no middlewares are provided, the default middlewares will be used.
-   * @param {GraphTelemetryOption} graphTelemetryOption - The telemetry options for the Graph client.
-   * @param {(request: string, init: RequestInit) => Promise<Response>} customFetch - The custom fetch function to use for HTTP requests.
-   * @param {BaseBearerTokenAuthenticationProvider} [authenticationProvider] - Optional authentication provider for bearer token.
-   * @param {Middleware[]} [middlewares] - Optional array of middleware to use in the HTTP pipeline.
-   * @returns {GraphHttpClient} - A new instance of `GraphHttpClient`.
-   * @example
-   * ```Typescript
-   * // Example usage of GraphClientFactory.create method with graphTelemetryOption , customFetch and middlewares parameters provided
-   *  GraphClientFactory.create(graphTelemetryOption, customFetch, [middleware1, middleware2]);
-   * ```
-   * @example
-   * ```Typescript
-   * // Example usage of GraphClientFactory.create method with only graphTelemetryOption and customFetch parameter provided
-   * GraphClientFactory.create(graphTelemetryOption, customFetch);
-   * ```
-   * @example
-   * ```Typescript
-   * // Example usage of GraphClientFactory.create method with only graphTelemetryOption and middlewares parameter provided
-   * GraphClientFactory.create(graphTelemetryOption, undefined, [middleware1, middleware2]);
-   * ```
-   * @example
-   * ```Typescript
-   * // Example usage of GraphClientFactory.create method with only graphTelemetryOption parameter provided
-   * GraphClientFactory.create(graphTelemetryOption);
-   * ```
-   */
-  public static create(
-    graphTelemetryOption: GraphTelemetryOption,
-    customFetch: ((request: string, init: RequestInit) => Promise<Response>) | undefined,
-    authenticationProvider?: BaseBearerTokenAuthenticationProvider,
-    middlewares?: Middleware[],
-  ): GraphHttpClient {
-    const middleware =
-      middlewares ||
-      getDefaultMiddlewares(
-        {
-          customFetch,
-          graphTelemetryOption,
-        },
-        authenticationProvider,
-      );
-    return new GraphHttpClient(graphTelemetryOption, customFetch, ...middleware);
-  }
-}
+export const createGraphClientFactory = (
+  graphTelemetryOption: GraphTelemetryOption,
+  customFetch?: (request: string, init: RequestInit) => Promise<Response>,
+  authenticationProvider?: BaseBearerTokenAuthenticationProvider,
+  middlewares?: Middleware[],
+): GraphHttpClient => {
+  const middleware =
+    middlewares ||
+    getDefaultMiddlewares(
+      {
+        customFetch,
+        graphTelemetryOption,
+      },
+      authenticationProvider,
+    );
+  return new GraphHttpClient(graphTelemetryOption, customFetch, ...middleware);
+};

test/http/GraphHttpClient.ts

@@ -2,7 +2,7 @@ import { assert, describe, it } from "vitest";
 import { GraphHttpClient, GraphTelemetryOption } from "../../src";
 import { BaseBearerTokenAuthenticationProvider } from "@microsoft/kiota-abstractions";
 import type { Middleware } from "@microsoft/kiota-http-fetchlibrary";
-import { GraphClientFactory } from "../../src/http/GraphClientFactory";
+import { createGraphClientFactory } from "../../src/http/GraphClientFactory";
 
 const graphTelemetryOption: GraphTelemetryOption = {};
 
@@ -40,7 +40,7 @@ describe("GraphHttpClient tests", () => {
       assert.equal(8, count);
 
       const authenticationProvider = new BaseBearerTokenAuthenticationProvider({} as any);
-      const clientWithProvider = GraphClientFactory.create(graphTelemetryOption, undefined, authenticationProvider);
+      const clientWithProvider = createGraphClientFactory(graphTelemetryOption, undefined, authenticationProvider);
       const count2 = countMiddlewares((clientWithProvider as any)["middleware"] as Middleware);
       assert.equal(9, count2);
     });