Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 16, 2025

Restructured SCSS codebase to follow Angular Material best practices, preparing for future M3 migration. Added comprehensive documentation and eliminated technical debt.

Changes

Documentation & Structure

  • Added JSDoc-style comments documenting theme configuration, mixins, and component patterns
  • Created SCSS_MIGRATION_GUIDE.md with M3 migration instructions and API mapping
  • Organized component imports by type (interactive, layout, content, feedback)
  • Separated utility exports (@forward) from includes (@use)

Code Quality

  • Consolidated duplicate rules (e.g., status/priority span color overrides)
  • Removed 226 lines of commented-out legacy code
  • Standardized nested selectors and formatting
  • Fixed inconsistent property usage (box-shadow vs -webkit-box-shadow)

M3 Preparation

  • Documented all 42 M2 API usages (m2-define-*, m2-get-*) for systematic replacement
  • Structured theme.scss into clear sections: typography → colors → theme application → overrides
  • Maintained backward compatibility while enabling 2-4 hour migration window

Migration Path Example

Current (M2):

@mixin color($theme) {
  $color-config: mat.m2-get-color-config($theme);
  $primary: map.get($color-config, 'primary');
  color: mat.m2-get-color-from-palette($primary, 500);
}

Future (M3):

@mixin color($theme) {
  color: mat.get-theme-color($theme, primary);
}

All M2 references catalogued in migration guide for systematic replacement across 7 component files.

Files Modified

  • 11 SCSS files (theme, components, utilities)
  • +993 lines (documentation), -226 lines (cleanup)
  • Zero bundle size impact
Original prompt

This section details on the original issue you should resolve

<issue_title>Refactor scss files to best practice for migrating to m3</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI and others added 2 commits November 16, 2025 13:54
…st practices

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor SCSS files for migrating to M3 Refactor SCSS for M3 migration readiness with comprehensive documentation Nov 16, 2025
Copilot AI requested a review from renemadsen November 16, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor scss files to best practice for migrating to m3

3 participants