Commit 6bc474e
fix(node-adapter): handle utf-8 characters split across stream chunks (#1496)
## Summary
- use `StringDecoder` to decode stream content safely across chunk
boundaries
- add tests for JSON and text bodies with UTF-8 characters split between
chunks
## Problem
Direct `chunk.toString()` decoding can corrupt UTF-8 characters when
multi-byte sequences are split across stream chunks.
## Testing
- added unit tests for chunk-boundary UTF-8 decoding in JSON body
- added unit tests for chunk-boundary UTF-8 decoding in text body
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Bug Fixes**
* Improved UTF‑8 decoding for streamed request bodies so multi‑byte
characters split across chunks are decoded correctly and incomplete
final bytes are handled gracefully (replacement character used).
* **Tests**
* Added tests validating JSON and plain‑text payloads with multi‑byte
UTF‑8 characters split across stream boundaries, including an incomplete
final byte scenario.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: zxhyc131 <zxhyc131@mercallure.com>
Co-authored-by: Dinh Le <dinwwwh@gmail.com>1 parent f30210a commit 6bc474e
2 files changed
+66
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
19 | 42 | | |
20 | 43 | | |
21 | 44 | | |
| |||
51 | 74 | | |
52 | 75 | | |
53 | 76 | | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
54 | 113 | | |
55 | 114 | | |
56 | 115 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | 2 | | |
4 | 3 | | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
| 118 | + | |
118 | 119 | | |
119 | 120 | | |
120 | | - | |
| 121 | + | |
121 | 122 | | |
122 | 123 | | |
123 | | - | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
124 | 127 | | |
125 | 128 | | |
126 | 129 | | |
| |||
0 commit comments