Commit a764ee3
authored
fix: Make signal in EventPublisherSubscribeIteratorOptions
If it isn't, while using the `signal` prop from the handler function, my
typescript complains with `exactOptionalPropertyTypes` enabled:
```
Argument of type '{ signal: AbortSignal | undefined; }' is not assignable to parameter of type 'EventPublisherSubscribeIteratorOptions' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
Types of property 'signal' are incompatible.
Type 'AbortSignal | undefined' is not assignable to type 'AbortSignal'.
Type 'undefined' is not assignable to type 'AbortSignal'.
```
Ref.: https://orpc.unnoq.com/docs/event-iterator#event-publisher
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Chores**
* Adjusted public API option to be more permissive with cancellation
signals, aligning types with existing behavior.
* No changes to runtime behavior or user-facing functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->AbortSignal | undefined (#928)1 parent b953b88 commit a764ee3
File tree
1 file changed
+1
-1
lines changed1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
0 commit comments