Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apiserver/dora/store/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def configure_db_with_app(app):

app.config["SQLALCHEMY_TRACK_MODIFICATIONS"] = False
app.config["SQLALCHEMY_DATABASE_URI"] = connection_uri
app.config["SQLALCHEMY_ENGINE_OPTIONS"] = {"pool_size": 20, "max_overflow": 5}
app.config["SQLALCHEMY_ENGINE_OPTIONS"] = {"pool_size": 10, "max_overflow": 5}
db.init_app(app)


Expand Down
4 changes: 2 additions & 2 deletions web-server/libdefs/ambient.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ declare type Org = {
created_at: Date;
name: string;
domain: string;
onboarding_steps: OnboardingStep[];
onboarding_state: OnboardingStep[];
integrations: Partial<IntegrationsMap>;
};

Expand Down Expand Up @@ -48,7 +48,7 @@ declare type IdentityMap = Record<
{ username: string; meta?: { avatar_url?: string } }
>;

declare type IntegrationsMap = Record<'github', true>;
declare type IntegrationsMap = Record<'github' | 'gitlab' | 'bitbucket', true>;

declare type User = {
id: string;
Expand Down
5 changes: 4 additions & 1 deletion web-server/pages/api/auth/session.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { NextApiResponse } from 'next/types';

import { getOnBoardingState } from '@/api/resources/orgs/[org_id]/onboarding';
import { Endpoint, nullSchema } from '@/api-helpers/global';
import { Table } from '@/constants/db';
import { db, getFirstRow } from '@/utils/db';
Expand Down Expand Up @@ -33,8 +34,10 @@ endpoint.handle.GET(nullSchema, async (_req, res) => {
getOrgDetails(),
getOrgIntegrations()
]);

const onboardingState = await getOnBoardingState(orgDetails.id);
res.send({
org: { ...orgDetails, org_onboarding_steps: [], integrations } || {}
org: { ...orgDetails, ...onboardingState, integrations } || {}
});
});

Expand Down
32 changes: 23 additions & 9 deletions web-server/pages/api/resources/orgs/[org_id]/onboarding.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,32 @@ const endpoint = new Endpoint(pathSchema);

endpoint.handle.GET(nullSchema, async (req, res) => {
const { org_id } = req.payload;
const results = await db(Table.UIPreferences)
.select(Columns[Table.UIPreferences].data)
.where(Columns[Table.UIPreferences].entity_id, org_id);
return res.send(results[0]?.data ?? { onboarding_state: [] });
return res.send(await getOnBoardingState(org_id));
});

endpoint.handle.PUT(putSchema, async (req, res) => {
const { org_id, onboarding_state } = req.payload;

return res.send(
await updateOnBoardingState(org_id, onboarding_state as OnboardingSteps[])
);
});

export default endpoint.serve();

export const getOnBoardingState = async (
org_id: string
): Promise<{ onboarding_state: OnboardingSteps[] }> => {
const results = await db(Table.UIPreferences)
.select(Columns[Table.UIPreferences].data)
.where(Columns[Table.UIPreferences].entity_id, org_id);
return results[0]?.data ?? { onboarding_state: [] };
};

export const updateOnBoardingState = async (
org_id: ID,
onboarding_state: OnboardingSteps[]
): Promise<{ onboarding_state: OnboardingSteps[] }> => {
const results = await db(Table.UIPreferences)
.insert({
entity_type: 'ORG',
Expand All @@ -46,8 +63,5 @@ endpoint.handle.PUT(putSchema, async (req, res) => {
])
.merge()
.returning('*');

return res.send(results[0]?.data ?? { onboarding_state: [] });
});

export default endpoint.serve();
return results[0]?.data ?? { onboarding_state: [] };
};
59 changes: 38 additions & 21 deletions web-server/pages/api/resources/orgs/[org_id]/teams/v2.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { groupBy, prop, uniq, mapObjIndexed, forEachObjIndexed } from 'ramda';
import { groupBy, prop, mapObjIndexed, forEachObjIndexed } from 'ramda';
import * as yup from 'yup';

import { enableOrgReposIfNotEnabled } from '@/api/integrations/orgs';
Expand All @@ -7,14 +7,17 @@ import {
getProviderOrgs,
getRepos
} from '@/api/internal/[org_id]/git_provider_org';
import {
getOnBoardingState,
updateOnBoardingState
} from '@/api/resources/orgs/[org_id]/onboarding';
import { getTeamRepos } from '@/api/resources/team_repos';
import { handleRequest } from '@/api-helpers/axios';
import { Endpoint } from '@/api-helpers/global';
import { Columns, Table } from '@/constants/db';
import { Integration } from '@/constants/integrations';
import { getTeamV2Mock } from '@/mocks/teams';
import { BaseTeam } from '@/types/api/teams';
import { ReqOrgRepo } from '@/types/resources';
import { OnboardingSteps, ReqOrgRepo } from '@/types/resources';
import { db, getFirstRow } from '@/utils/db';

const getSchema = yup.object().shape({
Expand Down Expand Up @@ -113,14 +116,21 @@ endpoint.handle.POST(postSchema, async (req, res) => {
org_repos
);

const [team, repos] = await Promise.all([
const [team, repos, onboardingState] = await Promise.all([
createTeam(org_id, name, []),
enableOrgReposIfNotEnabled(org_id, provider as Integration, orgReposList)
enableOrgReposIfNotEnabled(org_id, provider as Integration, orgReposList),
getOnBoardingState(org_id)
]);
const teamRepos = await addReposToTeam(
team.id,
repos.map((r) => r.id)
const updatedOnboardingState = Array.from(
new Set(onboardingState.onboarding_state).add(OnboardingSteps.TEAM_CREATED)
);
const [teamRepos] = await Promise.all([
addReposToTeam(
team.id,
repos.map((r) => r.id)
),
updateOnBoardingState(org_id, updatedOnboardingState)
]);

res.send({ team, teamReposMap: groupBy(prop('team_id'), teamRepos), repos });
});
Expand Down Expand Up @@ -182,27 +192,34 @@ const updateTeam = async (
team_name: string,
member_ids: string[]
): Promise<BaseTeam> => {
return handleRequest<BaseTeam>(`/team/${team_id}`, {
method: 'PATCH',
data: {
return db('Team')
.insert({
id: team_id,
name: team_name,
member_ids: uniq(member_ids)
}
});
member_ids: member_ids,
is_deleted: false,
updated_at: new Date()
})
.onConflict('id')
.merge()
.returning('*')
.then(getFirstRow);
};

const createTeam = async (
org_id: ID,
team_name: string,
member_ids: string[] = []
member_ids: string[]
): Promise<BaseTeam> => {
return handleRequest<BaseTeam>(`/org/${org_id}/team`, {
method: 'POST',
data: {
return db(Table.Team)
.insert({
org_id,
name: team_name,
member_ids: uniq(member_ids)
}
});
member_ids: member_ids,
is_deleted: false
})
.returning('*')
.then(getFirstRow);
};

const addReposToTeam = async (team_id: ID, repo_ids: ID[]) => {
Expand Down