Skip to content

evaluates badgeDetails for deployment frequency consitently for prev and curr #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024
Merged

evaluates badgeDetails for deployment frequency consitently for prev and curr #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions web-server/src/content/DoraMetrics/DoraCards/sharedHooks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { useAuth } from '@/hooks/useAuth';
import { doraMetricsSlice } from '@/slices/dora_metrics';
import { useDispatch, useSelector } from '@/store';
import { ChangeTimeModes, IntegrationGroup } from '@/types/resources';
import { getBadgeDetails } from '@/utils/adapt_deployment_frequency';
import { getDoraScore } from '@/utils/dora';

import {
Expand Down Expand Up @@ -205,26 +206,28 @@ export const usePropsForChangeTimeCard = () => {
};

export const useAvgWeeklyDeploymentFrequency = () => {
let avgDeploymentFrequency = useSelector(
(s) =>
s.doraMetrics.metrics_summary?.deployment_frequency_stats.current
.avg_daily_deployment_frequency || 0
const currentDeploymentFrequency = useSelector(
(s) => s.doraMetrics.metrics_summary?.deployment_frequency_stats.current
);
let prevAvgDeploymentFrequency = useSelector(
(s) =>
s.doraMetrics.metrics_summary?.deployment_frequency_stats.previous
.avg_daily_deployment_frequency || 0

const previousDeploymentFrequency = useSelector(
(s) => s.doraMetrics.metrics_summary?.deployment_frequency_stats.previous
);

const interval = 'week';
const avgDeploymentFrequency = getBadgeDetails(currentDeploymentFrequency);

const prevAvgDeploymentFrequency = getBadgeDetails(
previousDeploymentFrequency,
avgDeploymentFrequency.duration
);

const metricInterval = useMemo(() => {
return {
count: avgDeploymentFrequency,
prev: prevAvgDeploymentFrequency,
interval
count: avgDeploymentFrequency.avg_deployment_frequency,
prev: prevAvgDeploymentFrequency.avg_deployment_frequency,
interval: avgDeploymentFrequency.duration
};
}, [avgDeploymentFrequency, interval, prevAvgDeploymentFrequency]);
}, [avgDeploymentFrequency, prevAvgDeploymentFrequency]);

return useMemo(() => {
const key = updatedDeploymentFrequencyThresholds(metricInterval);
Expand Down
17 changes: 15 additions & 2 deletions web-server/src/utils/adapt_deployment_frequency.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,25 @@ const adaptTeamAnalytics = (
}));
};

const getBadgeDetails = (
data: Partial<UpdatedDeploymentFrequencyAnalyticsResponseV2>
const badgeDetailsToKey = {
day: 'avg_daily_deployment_frequency',
week: 'avg_weekly_deployment_frequency',
month: 'avg_monthly_deployment_frequency'
} as const;

export const getBadgeDetails = (
data: Partial<UpdatedDeploymentFrequencyAnalyticsResponseV2>,
duration?: 'day' | 'week' | 'month'
): {
avg_deployment_frequency: number;
duration: 'day' | 'week' | 'month';
} => {
if (duration) {
return {
avg_deployment_frequency: data[badgeDetailsToKey[duration]],
duration
};
}
if (data.avg_daily_deployment_frequency >= 1)
return {
avg_deployment_frequency: data.avg_daily_deployment_frequency,
Expand Down