Skip to content

Conversation

@samad-yar-khan
Copy link
Contributor

Why do we need this ?

  • Our existing approach of using sqlalchemy with flask wanst allowing us to make context bound sessions. It also made difficult for us to handle connection pools.

proposed chnages

  • Use Flask_SqlAlchmey
  • Updated init for repo
  • Update app init
  • Update requirements to add Flask_SqlAlchmey
  • Update all db models to use db.model and db.column
  • Update all repo services to stop roll_back_on_exec usages and use db object for session

dhruvagarwal
dhruvagarwal previously approved these changes Apr 16, 2024
@samad-yar-khan samad-yar-khan merged commit cfbdff5 into main Apr 17, 2024
@samad-yar-khan samad-yar-khan deleted the GROW-1325 branch April 17, 2024 06:24
@samad-yar-khan samad-yar-khan restored the GROW-1325 branch April 17, 2024 14:33
@amoghjalan amoghjalan deleted the GROW-1325 branch May 3, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants