Skip to content

Add rollback decorator #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 17, 2024
Merged

Add rollback decorator #99

merged 6 commits into from
Apr 17, 2024

Conversation

@samad-yar-khan
Copy link
Contributor

@samad-yar-khan samad-yar-khan commented Apr 17, 2024

Why do we need this ?

  • We need a new rollback decorator that can handle failed db calls.

Proposed changes

  • initialised _db in all class repo services so they can be passed in rollback
  • Add rollback decorator everywhere and used self._db in all repo services

amoghjalan
amoghjalan previously approved these changes Apr 17, 2024
View reviewed changes
@samad-yar-khan samad-yar-khan changed the title Add rollback dectrator Add rollback decorator Apr 17, 2024
@shivam-bit shivam-bit merged commit 90c127c into main Apr 17, 2024
@shivam-bit shivam-bit deleted the GROW-1325-1 branch April 17, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@shivam-bit shivam-bit shivam-bit approved these changes

@amoghjalan amoghjalan amoghjalan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samad-yar-khan @amoghjalan @shivam-bit