Proxy issue #282
Closed
Proxy issue #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please validate and merge this PR as this turns out to be a show-stopping problem for users sitting behind a corporate proxy. @ludovicderochethales thanks for your contribution it works and helped a lot for the aurelia generator 👍 |
Author
|
@zewa666 You're welcome! :) |
|
Can someone merge this pull request? I want to use Atom-sync-settings behind our corporate proxy :) |
|
Included in kaizensoze/node-github repo which has recently been merged into upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We've got an issue when using your library behind a corporate proxy. I fixed it using https-proxy-agent.
If you want to integrate in your version, feel free to do it :)
Thanks for your awesome work by the way!