Make compatible with Django 2.0 #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miki725
reviewed
Dec 21, 2017
url_filter/filtersets/django.py
Outdated
| such as ``ForeignKey``. | ||
| """ | ||
| try: | ||
| name = field.remote_field.name |
Owner
There was a problem hiding this comment.
usually this results is lower coverage when running against a particular version of a dep. maybe do something like this?
name = (getattr(field, 'remote_field', None) or field.rel).namethe or to make the evaluation lazy in case first one succeeds
I know this is not exactly pythonic but I guess Im a sucker for the coveted 100% coverage locally...
|
Hi, any news on that? |
|
Hi Team, Will this be implemented soon? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #50; fixes #49.