Skip to content

MBX-2529: Add parsing and validation models for abtests #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
enotniy merged 2 commits into from
Jun 13, 2023
Merged

MBX-2529: Add parsing and validation models for abtests #357

enotniy merged 2 commits into from
Jun 13, 2023

Conversation

@enotniy
Copy link
Collaborator

@enotniy enotniy commented Jun 7, 2023

Добавил валидаторы блока abtests и тесты для них

@enotniy enotniy force-pushed the feature/MBX-2529_1 branch 2 times, most recently from 30fe0e0 to 5059c65 Compare June 7, 2023 17:43
Robalim
Robalim reviewed Jun 9, 2023
View reviewed changes
...src/main/java/cloud/mindbox/mobile_sdk/inapp/data/repositories/MobileConfigRepositoryImpl.kt
private val mutex = Mutex()

private var inApps: List<InApp>? = null
private var operations: Map<OperationName, OperationSystemName>? = null
Copy link
Contributor

@Robalim Robalim Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Возможно стоит вынести в мобильный бэклог, перенос этих штук в sessionManager, выглядит, что в будущем это будет правильнее

Copy link
Collaborator Author

@enotniy enotniy Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавил тикет на исправление. Из-за этих штук тригерится парсинг несколько раз

dbvasilyev
dbvasilyev requested changes Jun 9, 2023
View reviewed changes
Copy link

@dbvasilyev dbvasilyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Договорились оторвать отсюда mixerFixedHash, и учесть те же замечания про логирования что и в предыдущем ПР-е.

@enotniy enotniy force-pushed the feature/MBX-2529_1 branch 2 times, most recently from 7e37e9f to f23a643 Compare June 9, 2023 12:41
@enotniy
Copy link
Collaborator Author

enotniy commented Jun 9, 2023 •
edited
Loading

Договорились оторвать отсюда mixerFixedHash, и учесть те же замечания про логирования что и в предыдущем ПР-е.

@dbvasilyev Про mixerFixedHash - убираю как и договорились.
Про логирование - можно поподробнее, на чем мы остановились?

  • Уровень логирования не тот?
  • Все логи с заглавной буквы?
  • Расписывать подробнее с контекстом?

@enotniy enotniy force-pushed the feature/MBX-2529_1 branch from f23a643 to f12e002 Compare June 9, 2023 12:56
@enotniy enotniy requested a review from dbvasilyev June 9, 2023 16:21
@dbvasilyev
Copy link

dbvasilyev commented Jun 13, 2023

Про логирование - можно поподробнее, на чем мы остановились?

Ровно на том что записано в аспекте https://www.notion.so/mindbox/SDK-71d53a778b9643a8a0fe0373f48061fd и на здравом смысле. Если в аспекте чего-то не хватает, надо дописывать.

@enotniy enotniy merged commit db2d040 into develop Jun 13, 2023
@enotniy enotniy deleted the feature/MBX-2529_1 branch June 13, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbvasilyev dbvasilyev dbvasilyev approved these changes

@sergeysozinov sergeysozinov Awaiting requested review from sergeysozinov

+1 more reviewer

@Robalim Robalim Robalim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@enotniy @dbvasilyev @Robalim