WMSDK-510: Remove fatal error through loadPersistentStores, add fallbacks and states. New trim DB size if needed. #594
Conversation
…acks and states. New trim DB size if needed.
justSmK
force-pushed
the
feature/WMSDK-510-fatalError-MBLogger
branch
from
cc35567 to
189c7f5
Compare
justSmK
force-pushed
the
feature/WMSDK-510-fatalError-MBLogger
branch
from
189c7f5 to
4562b9e
Compare
| public let writesPerTrimCheck: Int | ||
| public let trimCooldownSec: TimeInterval | ||
|
|
||
| public static let `default` = LoggerDBConfig( |
There was a problem hiding this comment.
Это просто эвристические параметры?
There was a problem hiding this comment.
Да. Удобно вынести стало из-за их роста и для подстановки в тесты
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the MindboxLogger Core Data management system to remove fatal errors during store loading, adds better error handling with fallback states, and implements a new database trimming mechanism to manage storage size.
- Replace fatal errors with graceful degradation to a disabled state when database loading fails
- Add comprehensive database trimming functionality with configurable policies for managing store size
- Refactor persistence loading into a modular loader system with better error recovery
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| MindboxLogger/Shared/LoggerRepository/MBLoggerCoreDataManager.swift | Main refactor removing fatal errors, adding state management and trimming logic |
| MindboxLogger/Shared/LoggerRepository/LoggerDatabaseLoader.swift | New modular database loader with auto-recovery from corruption |
| MindboxLogger/Shared/LoggerRepository/LogStoreTrimmer.swift | New trimming component with configurable policies and cooldown management |
| MindboxLogger/Shared/LoggerRepository/SQLiteLogicalSizeMeasurer.swift | New component for measuring actual SQLite database size |
| MindboxLogger/Shared/LoggerRepository/LoggerDBConfig.swift | Configuration structure for database management policies |
| MindboxTests/MindboxLogger/MBLoggerCoreDataManagerTests.swift | Updated tests for new functionality and refactored test helpers |
| MindboxTests/MindboxLogger/Mocks/TestContainers.swift | New test mocks for database loading scenarios |
| MindboxTests/MindboxLogger/LoggerDatabaseLoaderTests.swift | Tests for the new database loader functionality |
| MindboxTests/MindboxLogger/LogStoreTrimmerTests.swift | Tests for the trimming component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| let sizeKB = precomputedSizeKB ?? sizeMeasurer.sizeKB() | ||
| guard let fraction = computeTrimFraction(sizeKB: sizeKB, limitKB: config.dbSizeLimitKB) else { return false } | ||
| try delete(fraction) | ||
| cooldownUntil = clock.now.addingTimeInterval(config.trimCooldownSec) |
There was a problem hiding this comment.
А почему не наоборот? Хранить последнее время и каждый раз проверять добавляя интервал
There was a problem hiding this comment.
Удобно было сделать deadline "до какого времени нельзя". Но можно и как ты предложил. Пока нигде не аффектят оба варианта.
Issue