Add line items #150
Merged
Add line items #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sebastianMindee
left a comment
sebastianMindee
left a comment
There was a problem hiding this comment.
Now that merge_polygons_as_polygon exists, merge_polygons_as_bounding_box basically becomes redundant, as it's equivalent to a get_bounding_box on the resulting merged polygon anyway. Should we get rid of it?
Contributor
Author
Good point, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
✨ add basic support for line items
(copied from internal library)
How Has This Been Tested
New unit tests added.
Types of changes