Skip to content

Fix/card design #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 14, 2025
Merged

Fix/card design #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fb46b65
Merge pull request #169 from mindfiredigital/dev
anandmindfire Apr 14, 2025
80519be
Merge pull request #170 from mindfiredigital/dev
anandmindfire Apr 14, 2025
5cf0e7b
feat: sort cards according to stars
ayusmanmindfire Apr 14, 2025
cf0fd62
feat: sort cards according to stars
ayusmanmindfire Apr 14, 2025
7aafd8b
Merge branch 'fix/cardDesign' of https://github.com/ayusmanmindfire/m…
ayusmanmindfire Apr 14, 2025
4ea9ed3
fix: fix spacing for tags
ayusmanmindfire Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 29 additions & 55 deletions src/app/projects/components/ProjectCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,14 @@ export default function ProjectCard({
stars,
tags,
}: Props) {
const [showAllTags, setShowAllTags] = useState(false);
const [expandDescription, setExpandDescription] = useState(false);

return (
<div className='border-2 p-8 transition-[box-shadow] shadow-none hover:shadow-xl bg-slate-50/70 max-w-full h-64 flex flex-col relative'>
<div className='border-2 p-6 transition-[box-shadow] shadow-none hover:shadow-xl bg-slate-50/70 max-w-full h-64 flex flex-col relative'>
{/* Top content section */}
<div className='flex-1 flex flex-col overflow-hidden'>
<div className='flex justify-between items-start mb-3'>
<h3 className='font-bold text-lg tracking-widest text-mindfire-text-black capitalize truncate pr-2'>
<h3 className='font-bold text-lg tracking-widest text-mindfire-text-black capitalize pr-2'>
{title}
</h3>
{parentTitle !== "Upcoming Projects" && stars !== undefined && (
Expand All @@ -45,71 +44,46 @@ export default function ProjectCard({
)}
</div>

{/*Description that expands on click */}
{/* Description section with fixed height */}
<div
className={`mb-3 relative cursor-pointer ${
expandDescription ? "max-h-[72px] overflow-y-auto" : ""
}`}
onClick={() => setExpandDescription(!expandDescription)}
onClick={() => {
if (shortDescription.length > 120)
setExpandDescription(!expandDescription);
}}
style={{
minHeight: expandDescription ? "auto" : "4.1rem",
}}
>
<p
className={`text-mf-dark tracking-wide leading-6 ${
expandDescription ? "" : "line-clamp-3"
expandDescription ? "" : "line-clamp-2"
}`}
>
{shortDescription}
</p>
{expandDescription && (
<span className='text-xs text-blue-500 mt-1 block'>less</span>

{/* Only show toggle if the content is long */}
{shortDescription.length > 120 && (
<span className='text-xs text-blue-500 mt-1 block'>
{expandDescription ? "less" : "more"}
</span>
)}
</div>

{parentTitle !== "Upcoming Projects" && tags && tags.length > 0 && (
<div className='mb-2'>
<div
className={`flex gap-2 max-w-full ${
showAllTags ? "overflow-x-auto pb-2" : "overflow-hidden"
}`}
>
{showAllTags
? tags.map((tag, index) => (
<span
key={index}
className='px-2 py-1 text-xs bg-gray-100 text-gray-600 rounded-full border border-red-500 truncate flex-shrink-0'
>
{tag}
</span>
))
: tags.slice(0, 2).map((tag, index) => (
<span
key={index}
className='px-2 py-1 text-xs bg-gray-100 text-gray-600 rounded-full border border-red-500 truncate max-w-[100px]'
>
{tag}
</span>
))}
{!showAllTags && tags.length > 2 && (
<button
onClick={(e) => {
e.stopPropagation();
setShowAllTags(true);
}}
className='px-2 py-1 text-xs bg-gray-100 text-gray-600 rounded-full hover:bg-gray-200 cursor-pointer'
>
+{tags.length - 2} more
</button>
)}
{showAllTags && (
<button
onClick={(e) => {
e.stopPropagation();
setShowAllTags(false);
}}
className='px-2 py-1 text-xs bg-gray-100 text-gray-600 rounded-full hover:bg-gray-200 cursor-pointer flex-shrink-0'
<div className='mt-1'>
<div className={`flex gap-2 max-w-full overflow-x-auto pb-2' `}>
{tags.map((tag, index) => (
<span
key={index}
className='px-2 py-1 text-xs bg-gray-100 text-gray-600 rounded-full border border-red-500 truncate flex-shrink-0'
>
Show less
</button>
)}
{tag}
</span>
))}
</div>
</div>
)}
Expand All @@ -119,9 +93,9 @@ export default function ProjectCard({
{parentTitle !== "Upcoming Projects" &&
(githubUrl || documentationUrl) &&
(githubUrl !== "NA" || documentationUrl !== "NA") && (
<div className='absolute bottom-0 left-0 right-0 mx-8'>
<div className='border-t-2 my-2'></div>
<div className='flex gap-4 justify-center my-2'>
<div className='mt-2'>
<div className='border-t-2'></div>
<div className='flex gap-4 justify-center mt-2'>
{githubUrl && githubUrl !== "NA" && (
<Link
href={githubUrl}
Expand Down
6 changes: 5 additions & 1 deletion src/app/projects/components/ProjectGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ interface Props {
}

export default function ProjectGrid({ title, projectData }: Props) {
const sortedProjects = [...projectData].sort(
(a, b) => (b.stars ?? 0) - (a.stars ?? 0)
);

return (
<section className='mt-20' id='all-projects'>
<div className='flex justify-center items-center gap-4'>
Expand All @@ -31,7 +35,7 @@ export default function ProjectGrid({ title, projectData }: Props) {
<ProjectCount totalProjects={projectData.length} />
</div>
<div className='mt-12 px-4 grid gap-6 max-w-6xl mx-auto md:grid-cols-2 lg:grid-cols-3'>
{projectData.map(
{sortedProjects.map(
(
{
title: projectTitle,
Expand Down