Skip to content

Fix horizon and vertical scrolling issue in projects card #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

Fix horizon and vertical scrolling issue in projects card #174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4e1218
fix: fix spacing between contents
ayusmanmindfire Apr 14, 2025
6acb6ec
Merge pull request #173 from ayusmanmindfire/fix/cardDesign
anandmindfire Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions src/app/projects/components/ProjectCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ export default function ProjectCard({
const [expandDescription, setExpandDescription] = useState(false);

return (
<div className='border-2 p-6 transition-[box-shadow] shadow-none hover:shadow-xl bg-slate-50/70 max-w-full h-64 flex flex-col relative'>
{/* Top content section */}
<div className='border-2 p-6 transition-[box-shadow] shadow-none hover:shadow-xl bg-slate-50/70 max-w-full h-80 flex flex-col relative'>
<div className='flex-1 flex flex-col overflow-hidden'>
<div className='flex justify-between items-start mb-3'>
<h3 className='font-bold text-lg tracking-widest text-mindfire-text-black capitalize pr-2'>
<div className='flex justify-between items-start mb-2 h-[60px]'>
<h3 className='font-bold text-lg tracking-widest text-mindfire-text-black line-clamp-2 capitalize pr-2 overflow-hidden'>
{title}
</h3>

{parentTitle !== "Upcoming Projects" && stars !== undefined && (
<div className='flex items-center gap-1 bg-gray-100 rounded-full p-1 flex-shrink-0'>
<AiFillStar className='text-yellow-400' />
Expand All @@ -44,38 +44,37 @@ export default function ProjectCard({
)}
</div>

{/* Description section with fixed height */}
{/* Description - fixed height with toggleable expansion */}
<div
className={`mb-3 relative cursor-pointer ${
expandDescription ? "max-h-[72px] overflow-y-auto" : ""
}`}
className={`relative cursor-pointer transition-all duration-300 h-[90px] ${
expandDescription
? "max-h-[90px] overflow-y-auto"
: "max-h-[5.5rem] overflow-hidden"
} mb-4`}
onClick={() => {
if (shortDescription.length > 120)
setExpandDescription(!expandDescription);
}}
style={{
minHeight: expandDescription ? "auto" : "4.1rem",
}}
>
<p
className={`text-mf-dark tracking-wide leading-6 ${
expandDescription ? "" : "line-clamp-2"
expandDescription ? "" : "line-clamp-3"
}`}
>
{shortDescription}
</p>

{/* Only show toggle if the content is long */}
{/* Show toggle outside the paragraph */}
{shortDescription.length > 120 && (
<span className='text-xs text-blue-500 mt-1 block'>
{expandDescription ? "less" : "more"}
</span>
)}
</div>

{/* Tags section - fixed height + horizontal scroll if overflow */}
{parentTitle !== "Upcoming Projects" && tags && tags.length > 0 && (
<div className='mt-1'>
<div className={`flex gap-2 max-w-full overflow-x-auto pb-2' `}>
<div className='h-[2.5rem]'>
<div className='flex gap-2 max-w-full overflow-x-auto pb-1'>
{tags.map((tag, index) => (
<span
key={index}
Expand Down