Skip to content

Fix compliance with original recv_into() #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Fix compliance with original recv_into() #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mocket/mocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def sendall(self, data, entry=None, *args, **kwargs):
def read(self, buffersize):
return self.fd.read(buffersize)

def recv_into(self, buffer, buffersize, flags=None):
def recv_into(self, buffer, buffersize=None, flags=None):
return buffer.write(self.fd.read(buffersize))

def recv(self, buffersize, flags=None):
Expand Down
4 changes: 2 additions & 2 deletions tests/main/test_mocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def test_getresponse(self):
def test_empty_getresponse(self):
entry = MocketEntry(('localhost', 8080), [])
self.assertEqual(entry.get_response(), encode_to_bytes(''))

def test_subsequent_recv_requests_have_correct_length(self):
Mocket.register(
MocketEntry(
Expand Down Expand Up @@ -119,7 +119,7 @@ def test_recv_into(self):
_so.sendall(b'first\r\n')
assert _so.recv_into(buffer, 4096) == 12
_so.sendall(b'second\r\n')
assert _so.recv_into(buffer, 4096) == 5
assert _so.recv_into(buffer) == 5
_so.close()
buffer.seek(0)
assert buffer.read() == b'Long payloadShort'
Expand Down