Use LayeredIcon for mixin classes
#2340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedNesto
reviewed
Jul 30, 2024
RedNesto
reviewed
Jul 30, 2024
Contributor
Author
|
Excuse the impatience, does this look good? (The old icon is irritating a bit) |
RedNesto
approved these changes
Aug 1, 2024
Earthcomputer
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Newly introduced mixin files icons look awkward - pixelation becomes noticable, they don't fit with the Intellij icon style and don't convey the information about the type of the class:
Solution
Intellij supports layered icons, similar to Kotlin classes, which are more visually pleasing:
New UI - dark
Old UI - dark