clean up tests and add some comments #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariux
commented
Jan 12, 2020
mariux
force-pushed
the
mariux/clean-up-tests
branch
from
726b2ee to
04cbb92
Compare
soerenmartius
requested changes
Jan 12, 2020
Member
|
ok, another lesson learned
…On Sun, Jan 12, 2020 at 2:03 PM Marius Tolzmann ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Dockerfile
<#15 (comment)>
:
> @@ -14,8 +14,9 @@ RUN apk add --update bash curl git openssl python3 terraform
RUN pip3 install pre-commit
# Download Tflint
-ADD https://github.com/terraform-linters/tflint/releases/download/${TFLINT_VERSION}/tflint_linux_amd64.zip .
-ADD https://github.com/terraform-linters/tflint/releases/download/${TFLINT_VERSION}/checksums.txt .
+RUN wget \
To not redownload every run and tiger all later layers to be rebuild.. so
it is 100% cachable
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#15?email_source=notifications&email_token=AAHDGU7WS2LE6W463KZL5IDQ5MILLA5CNFSM4KFVJTLKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCROADDQ#discussion_r365581756>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHDGU7BYVCLAOCHK244NJTQ5MILLANCNFSM4KFVJTLA>
.
|
mariux
force-pushed
the
mariux/clean-up-tests
branch
5 times, most recently
from
5eaefd4 to
f5bf80d
Compare
when adding a user to a team that is not member of the organization, the user will be invited to the organization. when removing the member again from the team the invitation will still be outstanding and not removed during terraform destroy.
mariux
force-pushed
the
mariux/clean-up-tests
branch
from
f5bf80d to
2cce475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.